Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 390733002: Revert of Remove media::VideoRenderer::SetPlaybackRate(). (Closed)

Created:
6 years, 5 months ago by falken
Modified:
6 years, 5 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert of Remove media::VideoRenderer::SetPlaybackRate(). (https://codereview.chromium.org/384943002/) Reason for revert: Sorry to revert this change. It made the following layout tests flakily fail: media/track/track-cue-rendering-horizontal.html media/track/track-cue-rendering-vertical.html Reverting locally healed the tests. The image diffs show what appears to be a timestamp change (something like 0:18 to 0:19): https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux__dbg_/20779/layout-test-results/results.html Original issue's description: > Remove media::VideoRenderer::SetPlaybackRate(). > > Video renderers don't need the information as they are already making > audio/video synchronization decisions based on a media timeline that > already incorporates the current playback rate via the time callback. > > In particular, VideoRendererImpl only used playback rate to estimate > a better duration to sleep until the current frame was ready ... > except that in most cases we'd sleep for kIdleTimeDelta and wait > until the media timeline had progressed past the current frame's > timestamp. In other words, there's absolutely no reason to even try > to estimate the sleep duration based on the playback rate. > > BUG=370634 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282797 TBR=xhwang@chromium.org,scherkus@chromium.org NOTREECHECKS=true NOTRY=true BUG=370634 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282891

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -23 lines) Patch
M media/base/mock_filters.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/pipeline.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M media/base/pipeline_unittest.cc View 4 chunks +4 lines, -0 lines 0 comments Download
M media/base/video_renderer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M media/filters/video_renderer_impl.h View 3 chunks +11 lines, -0 lines 0 comments Download
M media/filters/video_renderer_impl.cc View 6 chunks +41 lines, -23 lines 0 comments Download
M media/filters/video_renderer_impl_unittest.cc View 3 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
falken
Created Revert of Remove media::VideoRenderer::SetPlaybackRate().
6 years, 5 months ago (2014-07-14 02:46:44 UTC) #1
falken
The CQ bit was checked by falken@chromium.org
6 years, 5 months ago (2014-07-14 02:47:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/falken@chromium.org/390733002/1
6 years, 5 months ago (2014-07-14 02:48:36 UTC) #3
commit-bot: I haz the power
6 years, 5 months ago (2014-07-14 02:49:00 UTC) #4
Message was sent while issue was closed.
Change committed as 282891

Powered by Google App Engine
This is Rietveld 408576698