Issue 390673002: Replace uses of {un}setPendingActivity() in FetchBodyStream.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 390673002: Replace uses of {un}setPendingActivity() in FetchBodyStream. (Closed)

Created:
6 years, 5 months ago by sof

Modified:
6 years, 5 months ago

Reviewers:
haraken, kouhei (in TOK)

CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org, alecflett+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Replace uses of {un}setPendingActivity() in FetchBodyStream. Follow up r178002 and provide FetchBodyStream::hasPendingActivity() rather than updating ActiveDOMObject's refcount-based pending counts. This lets the class derive from the simpler Oilpan GC class (GarbageCollectedFinalized) rather than RefCountedGarbageCollected. R=haraken@chromium.org,kouhei@chromium.org BUG=354845 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178009

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -9 lines)			Patch
	M	Source/modules/serviceworkers/FetchBodyStream.h	View		2 chunks	+2 lines, -4 lines	0 comments	Download
	M	Source/modules/serviceworkers/FetchBodyStream.cpp	View		5 chunks	+6 lines, -5 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/390673002/1

6 years, 5 months ago (2014-07-13 06:06:50 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...

6 years, 5 months ago (2014-07-13 07:07:16 UTC) #5

Message was sent while issue was closed.

Change committed as 178009

Expand Messages | Collapse Messages