Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 390613004: CdmAdapter: Value initialize PP_Decrypted*Info. (Closed)

Created:
6 years, 5 months ago by xhwang
Modified:
6 years, 5 months ago
Reviewers:
ddorwin, earthdok
CC:
chromium-reviews, feature-media-reviews_chromium.org, yusukes+watch_chromium.org, tzik, binji+watch_chromium.org, raymes+watch_chromium.org, eme-reviews_chromium.org, teravest+watch_chromium.org, nfullagar1, piman+watch_chromium.org, noelallen1, ihf+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

CdmAdapter: Value initialize PP_Decrypted*Info. Previously there care cases where those structs are only partially initialized. TBR=ddorwin@chromium.org BUG=393938 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283335

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M media/cdm/ppapi/cdm_adapter.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
xhwang
PTAL
6 years, 5 months ago (2014-07-15 17:24:37 UTC) #1
earthdok
On 2014/07/15 17:24:37, xhwang wrote: > PTAL verified, lgtm
6 years, 5 months ago (2014-07-15 17:43:23 UTC) #2
xhwang
earthdok: Thanks for the review and verification! TBRing ddorwin...
6 years, 5 months ago (2014-07-15 17:50:46 UTC) #3
xhwang
The CQ bit was checked by xhwang@chromium.org
6 years, 5 months ago (2014-07-15 17:50:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/390613004/1
6 years, 5 months ago (2014-07-15 17:52:47 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-16 00:58:33 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-16 01:23:41 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/170939)
6 years, 5 months ago (2014-07-16 01:23:41 UTC) #8
ddorwin
lgtm
6 years, 5 months ago (2014-07-16 01:41:02 UTC) #9
xhwang
The CQ bit was checked by xhwang@chromium.org
6 years, 5 months ago (2014-07-16 03:32:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/390613004/1
6 years, 5 months ago (2014-07-16 03:35:20 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 04:38:40 UTC) #12
Message was sent while issue was closed.
Change committed as 283335

Powered by Google App Engine
This is Rietveld 408576698