Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 390553003: Re-anchors the permission bubble when its parent window has moved. (Closed)

Created:
6 years, 5 months ago by leng
Modified:
6 years, 5 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@bubble_in_fullscreen
Project:
chromium
Visibility:
Public.

Description

Re-anchors the permission bubble when its parent window has moved. BUG=381290 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284574

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : GetAnchorPoint, not AnchorPoint #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm View 1 2 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
leng
This is the CL that depends on the bubble-visible-in-fullscreen-mode CL: https://codereview.chromium.org/390503003/ Specifically, for the AnchorPoint() ...
6 years, 5 months ago (2014-07-11 23:01:53 UTC) #1
Robert Sesek
lgtm
6 years, 5 months ago (2014-07-14 14:15:03 UTC) #2
leng
The CQ bit was checked by leng@chromium.org
6 years, 5 months ago (2014-07-21 16:14:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leng@chromium.org/390553003/20001
6 years, 5 months ago (2014-07-21 16:15:49 UTC) #4
leng
The CQ bit was checked by leng@chromium.org
6 years, 5 months ago (2014-07-21 16:25:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leng@chromium.org/390553003/40001
6 years, 5 months ago (2014-07-21 16:26:56 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-21 18:57:40 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-21 19:43:31 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/41174)
6 years, 5 months ago (2014-07-21 19:43:32 UTC) #9
leng
The CQ bit was checked by leng@chromium.org
6 years, 5 months ago (2014-07-21 21:11:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leng@chromium.org/390553003/40001
6 years, 5 months ago (2014-07-21 21:12:56 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-21 23:02:30 UTC) #12
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 01:03:13 UTC) #13
Message was sent while issue was closed.
Change committed as 284574

Powered by Google App Engine
This is Rietveld 408576698