Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 390553002: NaCl: Update revision in DEPS, r13456 -> r13477 (Closed)

Created:
6 years, 5 months ago by Derek Schuff
Modified:
6 years, 5 months ago
CC:
chromium-reviews, David Yen, earthdok, hamaji, JF, jvoung (off chromium), native-client-reviews_googlegroups.com, noelallen_use_chromium, sehr, sky
Project:
chromium
Visibility:
Public.

Description

NaCl: Update revision in DEPS, r13456 -> r13484 This pulls in the following Native Client changes: r13457: (dyen) LLVM Regression tests check for build files instead of empty dirs. r13458: (noelallen) Update and add GN files to build sel_ldr. r13459: (jvoung) Remove env cleanser references to obsolete env vars. r13460: (jfb) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS r13461: (hamaji) Non-SFI Mode: Add prctl syscall wrapper r13462: (hamaji) Non-SFI Mode: Implement IRT fstat r13463: (hamaji) Correct the return type of TestSuite in timefuncs_test r13464: (hamaji) syscall_test: Do not test st_atime in the test for fstat r13465: (earthdok) Implement initial MSan support. Also, adjust ASan build flags. r13466: (dschuff) pnacl-ld: Do not attempt to parse ELF or bitcode files as linker scripts r13467: (jvoung) Remove NaClSrpcIsStandalone() function. r13468: (dschuff) Make testing architecture explicit PNaCl toolchain buildbot script r13469: (dschuff) Stub out pnacl-opt and pnacl-finalize tools for scons built_elsewhere=1 r13470: (dschuff) Update revision for PNaCl r13392->r13466 r13471: (noelallen) Build nacl_bootstrap_helper and test with GN scons r13472: (dschuff) Build PNaCl with mingw again r13473: (earthdok) Zap the NaClSignalContext struct in SignalCatch. r13474: (dschuff) Update revision for PNaCl r13466->r13472 r13475: (sehr) Munge nacl_helper_bootstrap using python rather than libelf r13476: (sky) Changes scan_sources not to output on bogus directory r13477: (dschuff) Reduce debugging metadata for pexe builds in Chrome r13480: (jfb) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS r13481: (hidehiko) Align at 16 bytes for stack for created thread. r13484: (jfb) Revert "Munge nacl_helper_bootstrap using python rather than libelf" BUG=none TEST=browser_tests and nacl_integration R=jvoung@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283271 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283448

Patch Set 1 #

Patch Set 2 : update to 13487 #

Patch Set 3 : back to 13484 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
Derek Schuff
looks sufficiently green that I'm going to try to land it. (This particular revision brings ...
6 years, 5 months ago (2014-07-14 16:09:08 UTC) #1
Derek Schuff
On 2014/07/14 16:09:08, Derek Schuff wrote: > looks sufficiently green that I'm going to try ...
6 years, 5 months ago (2014-07-14 16:11:01 UTC) #2
jvoung (off chromium)
lgtm
6 years, 5 months ago (2014-07-14 16:29:40 UTC) #3
Derek Schuff
The CQ bit was checked by dschuff@chromium.org
6 years, 5 months ago (2014-07-14 16:36:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dschuff@chromium.org/390553002/1
6 years, 5 months ago (2014-07-14 16:37:35 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_arm_cross_compile on tryserver.chromium ...
6 years, 5 months ago (2014-07-14 18:04:22 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-14 18:08:45 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_arm_cross_compile on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_arm_cross_compile/builds/273)
6 years, 5 months ago (2014-07-14 18:08:46 UTC) #8
Mark Seaborn
On 14 July 2014 09:11, <dschuff@chromium.org> wrote: > On 2014/07/14 16:09:08, Derek Schuff wrote: > ...
6 years, 5 months ago (2014-07-15 22:25:14 UTC) #9
Mark Seaborn
On 14 July 2014 09:11, <dschuff@chromium.org> wrote: > On 2014/07/14 16:09:08, Derek Schuff wrote: > ...
6 years, 5 months ago (2014-07-15 22:25:22 UTC) #10
Derek Schuff
Committed patchset #3 manually as r283271 (presubmit successful).
6 years, 5 months ago (2014-07-15 23:26:02 UTC) #11
Derek Schuff
On 2014/07/15 23:26:02, Derek Schuff wrote: > Committed patchset #3 manually as r283271 (presubmit successful). ...
6 years, 5 months ago (2014-07-16 15:55:57 UTC) #12
Derek Schuff
6 years, 5 months ago (2014-07-16 18:34:11 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 manually as r283448 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698