Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 390543002: Always use 48kHz for OPUS decoding. (Closed)

Created:
6 years, 5 months ago by DaleCurtis
Modified:
6 years, 5 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Always use 48kHz for OPUS decoding. Per the specification OPUS should always use 48kHz for decoding. BUG=392827 TEST=new unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282989

Patch Set 1 #

Patch Set 2 : Add test. #

Patch Set 3 : Test all teh things. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -47 lines) Patch
M media/ffmpeg/ffmpeg_common.cc View 2 chunks +9 lines, -1 line 0 comments Download
M media/ffmpeg/ffmpeg_common_unittest.cc View 1 3 chunks +19 lines, -46 lines 0 comments Download
M media/filters/pipeline_integration_test.cc View 1 2 1 chunk +28 lines, -0 lines 0 comments Download
M media/formats/webm/webm_audio_client.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
DaleCurtis
6 years, 5 months ago (2014-07-11 22:15:58 UTC) #1
DaleCurtis
FYI: We need this in FFmpegCommon instead of in the OPUS decoder as it'll be ...
6 years, 5 months ago (2014-07-11 22:19:57 UTC) #2
scherkus (not reviewing)
pipeline integration test?
6 years, 5 months ago (2014-07-11 23:06:12 UTC) #3
DaleCurtis
Too lazy to rebuild my encoding environment right now, added a FFmpegCommonTest.
6 years, 5 months ago (2014-07-11 23:27:54 UTC) #4
scherkus (not reviewing)
It's a good start ... but we should still land a pipeline integration test to ...
6 years, 5 months ago (2014-07-11 23:52:27 UTC) #5
DaleCurtis
Tests everywhere!
6 years, 5 months ago (2014-07-12 01:12:20 UTC) #6
scherkus (not reviewing)
thanks for writing tests! lgtm
6 years, 5 months ago (2014-07-14 16:38:52 UTC) #7
DaleCurtis
The CQ bit was checked by dalecurtis@chromium.org
6 years, 5 months ago (2014-07-14 16:46:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/390543002/40001
6 years, 5 months ago (2014-07-14 16:47:48 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-14 18:48:39 UTC) #10
Message was sent while issue was closed.
Change committed as 282989

Powered by Google App Engine
This is Rietveld 408576698