Bypassed Bytes UMAs

components/data_reduction_proxy/browser/data_reduction_proxy_protocol.cc

Index: components/data_reduction_proxy/browser/data_reduction_proxy_protocol.cc
diff --git a/components/data_reduction_proxy/browser/data_reduction_proxy_protocol.cc b/components/data_reduction_proxy/browser/data_reduction_proxy_protocol.cc
index a013f721be079c1dd00c028d3858be78fb14e196..961d4adf40280f5cc116227cf34d3d28f84f0f3e 100644
--- a/components/data_reduction_proxy/browser/data_reduction_proxy_protocol.cc
+++ b/components/data_reduction_proxy/browser/data_reduction_proxy_protocol.cc
@@ -35,6 +35,7 @@ bool SetProxyServerFromGURL(const GURL& gurl,
 namespace data_reduction_proxy {
 
 bool MaybeBypassProxyAndPrepareToRetry(
+    net::ProxyService::DataReductionProxyBypassType proxy_bypass_type,

[mef, 2014/07/15 18:20:04]

Should this be passed by pointer?

[megjablon, 2014/07/16 00:00:59]

Whoops, yes fixed.

     const DataReductionProxyParams* data_reduction_proxy_params,
     net::URLRequest* request,
     const net::HttpResponseHeaders* original_response_headers,
@@ -57,8 +58,9 @@ bool MaybeBypassProxyAndPrepareToRetry(
 
   DataReductionProxyInfo data_reduction_proxy_info;
   net::ProxyService::DataReductionProxyBypassType bypass_type =
-      GetDataReductionProxyBypassType(
-          original_response_headers, &data_reduction_proxy_info);
+      GetDataReductionProxyBypassType(original_response_headers,
+                                      &data_reduction_proxy_info);
+  proxy_bypass_type = bypass_type;

[mef, 2014/07/15 18:20:04]

Umm, what's the point of passing in |proxy_bypass_type| if it is always
overridden with |bypass_type|?

   if (bypass_type == net::ProxyService::BYPASS_EVENT_TYPE_MAX) {
     return false;
   }