Bypassed Bytes UMAs

tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index cee3bd4ed06b161e7253c1f46a1898a1d0ecdb4b..a3f18e1bdffe25a0d57f65ce8342e273268fadb1 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -2957,6 +2957,14 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   </summary>
 </histogram>
 
+<histogram name="DataReductionProxy.BypassedBytes" units="bytes">
+  <owner>bengr@chromium.org</owner>
+  <summary>
+    Counts bytes of various events that trigger Chrome to bypass the data
+    reduction proxy.
+  </summary>
+</histogram>
+
 <histogram name="DataReductionProxy.BypassInfoFallback"
     enum="DataReductionProxyBypassEventType_Deprecated">
   <obsolete>
@@ -48044,6 +48052,43 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   <affected-histogram name="PLT.PT_StartToFinish"/>
 </histogram_suffixes>
 
+<histogram_suffixes name="DataReductionProxyBypassedBytes" separator=".">

[bengr, 2014/07/14 22:04:30]

Why do we not just want an enumerated histogram?

[megjablon, 2014/07/15 18:02:50]

With an enumerated histogram we can't store the number of bytes, only how many
times an enumerated constant was used. This is the histograms_suffix construct
that Alexei told me about that creates a histogram for each type, and then we
can store the bytes in there.

+  <suffix name="NotBypassed" label="Not bypassed"/>
+  <suffix name="SSL" label="Bypass due to SSL"/>
+  <suffix name="LocalBypassRules"
+      label="Bypass due to client-side bypass rules"/>
+  <suffix name="Current" label="Bypass due to explicit instruction"/>
+  <suffix name="ShortAll" label="Short bypass"/>
+  <suffix name="ShortTriggeringRequest"
+      label="Triggering request short bypass"/>
+  <suffix name="ShortAudioVideo"
+      label="Audio/Video bypass due to short bypass"/>
+  <suffix name="MediumAll" label="Medium bypass"/>
+  <suffix name="MediumTriggeringRequest"
+      label="Triggering request medium bypass"/>
+  <suffix name="LongAll" label="Long bypass"/>
+  <suffix name="LongTriggering_Request" label="Triggering request long bypass"/>
+  <suffix name="MissingViaHeader4xx"
+      label="Bypass due to a 4xx missing via header"/>
+  <suffix name="MissingViaHeaderOther"
+      label="Bypass due to other missing via header"/>
+  <suffix name="Malformed407"
+      label="Bypass due to 407 response from proxy without a challenge"/>
+  <suffix name="Status500HttpInternalServerError"
+      label="Bypass due to internal server error"/>
+  <suffix name="Status502HttpBadGateway"
+      label="Bypass because the request URI was too long"/>
+  <suffix name="Status503HttpServiceUnavailable"
+      label="Bypass due to a 503 response"/>
+  <suffix name="NetworkErrorTimedOut" label="Bypass due to network timeout"/>
+  <suffix name="NetworkErrorProxyConnectionFailed"
+      label="Bypass due to failed proxy connection"/>
+  <suffix name="NetworkErrorProxyCertificateInvalid"
+      label="Bypass due to invalid proxy certificate"/>
+  <suffix name="NetworkErrorOther" label="Bypass due to any network error"/>
+  <affected-histogram name="DataReductionProxy.BypassedBytes"/>
+</histogram_suffixes>
+
 <histogram_suffixes name="DefaultAppsExperiment">
   <suffix name="NoDefaultApps" label="User's without default apps installed"/>
   <suffix name="WithDefaultApps" label="User's with default apps installed"/>