components/data_reduction_proxy/common/data_reduction_proxy_headers.cc - Issue 390533003: Bypassed Bytes UMAs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/common/data_reduction_proxy_headers.cc

Issue 390533003: Bypassed Bytes UMAs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed bengr comments Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/data_reduction_proxy/browser/data_reduction_proxy_usage_stats.cc ('K') | « components/data_reduction_proxy/browser/data_reduction_proxy_usage_stats.cc ('k') | components/data_reduction_proxy/common/data_reduction_proxy_headers_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/common/data_reduction_proxy_headers.cc

diff --git a/components/data_reduction_proxy/common/data_reduction_proxy_headers.cc b/components/data_reduction_proxy/common/data_reduction_proxy_headers.cc

index b5c6119080948ba3618b2c0d02b51fcb521eb860..15d35301f390f19d44de969bb7208a787ba03da2 100644

--- a/components/data_reduction_proxy/common/data_reduction_proxy_headers.cc

+++ b/components/data_reduction_proxy/common/data_reduction_proxy_headers.cc

@@ -114,6 +114,9 @@ GetDataReductionProxyBypassType(

// A chrome-proxy response header is only present in a 502. For proper

// reporting, this check must come before the 5xx checks below.

const TimeDelta& duration = data_reduction_proxy_info->bypass_duration;

+ // bypass=0 means bypass for a random duration between 1 to 5 minutes

+ if (duration == TimeDelta())

+ return ProxyService::MEDIUM_BYPASS;

if (duration <= TimeDelta::FromSeconds(kShortBypassMaxSeconds))

return ProxyService::SHORT_BYPASS;

if (duration <= TimeDelta::FromSeconds(kMediumBypassMaxSeconds))