Bypassed Bytes UMAs

components/data_reduction_proxy/browser/data_reduction_proxy_params.h

Index: components/data_reduction_proxy/browser/data_reduction_proxy_params.h
diff --git a/components/data_reduction_proxy/browser/data_reduction_proxy_params.h b/components/data_reduction_proxy/browser/data_reduction_proxy_params.h
index 7a8e9f4c9154f8d0e2dce7ad440516dc6b601b51..4ba8f899a313c3c3191f8f423365738b5d661dd3 100644
--- a/components/data_reduction_proxy/browser/data_reduction_proxy_params.h
+++ b/components/data_reduction_proxy/browser/data_reduction_proxy_params.h
@@ -11,6 +11,7 @@
 
 #include "base/macros.h"
 #include "net/base/host_port_pair.h"
+#include "net/proxy/proxy_retry_info.h"
 #include "url/gurl.h"
 
 namespace net {
@@ -92,6 +93,25 @@ class DataReductionProxyParams {
   // list.
   virtual bool IsDataReductionProxyEligible(const net::URLRequest* request);
 
+  // Checks if all configured data reduction proxies are in the retry map.
+  // Returns true if the request is bypassed by all configured data reduction
+  // proxies. If there are no configured data reduction proxies, returns false.
+  // It returns the bypass delay in delay_seconds (if not NULL). If

[bengr, 2014/07/19 00:13:01]

It returns --> and returns

[megjablon, 2014/07/21 19:44:44]

Done.

+  // the request is bypassed by more than one proxy, delay_seconds returns
+  // shortest delay.

[bengr, 2014/07/19 00:13:01]

the shortest

[megjablon, 2014/07/21 19:44:45]

Done.

+  bool WereDataReductionProxiesBypassed(const net::URLRequest& request,
+                                        int64* delay_seconds) const;
+
+  // Checks if all configured data reduction proxies are in the retry map.
+  // Returns true if the request is bypassed by all configured data reduction
+  // proxies. If there are no configured data reduction proxies, returns false.
+  // It returns the bypass delay in delay_seconds (if not NULL). If

[bengr, 2014/07/19 00:13:01]

It -> and

[megjablon, 2014/07/21 19:44:44]

Done.

+  // the request is bypassed by more than one proxy, delay_seconds returns
+  // shortest delay.

[bengr, 2014/07/19 00:13:01]

the shortest

[megjablon, 2014/07/21 19:44:45]

Done.

+  bool WereProxiesBypassed(const net::ProxyRetryInfoMap& retry_map,

[bengr, 2014/07/19 00:13:01]

AreProxies...?

I'm not sure if "bypassed" is the present state or a former one. I think it's
the present state, right?

[megjablon, 2014/07/21 19:44:44]

Done.

+                           bool ssl,
+                           int64* delay_second) const;
+
   // Returns the data reduction proxy primary origin.
   const GURL& origin() const {
     return origin_;
@@ -201,6 +221,11 @@ class DataReductionProxyParams {
 
   bool configured_on_command_line_;
 
+  bool WerePrimaryAndFallbackBypassed(const net::ProxyRetryInfoMap& retry_map,

[bengr, 2014/07/19 00:13:01]

Are?

[megjablon, 2014/07/21 19:44:45]

Done.

+                                      GURL primary,

[bengr, 2014/07/19 00:13:01]

These can be const GURL&.

[megjablon, 2014/07/21 19:44:45]

Done.

+                                      GURL fallback,
+                                      int64* delay_seconds) const;
+
   DISALLOW_COPY_AND_ASSIGN(DataReductionProxyParams);
 };