Bypassed Bytes UMAs

components/data_reduction_proxy/browser/data_reduction_proxy_protocol.cc

Index: components/data_reduction_proxy/browser/data_reduction_proxy_protocol.cc
diff --git a/components/data_reduction_proxy/browser/data_reduction_proxy_protocol.cc b/components/data_reduction_proxy/browser/data_reduction_proxy_protocol.cc
index a013f721be079c1dd00c028d3858be78fb14e196..c5e7fb87707a18f01a338180d6ebad9ce40fc9c2 100644
--- a/components/data_reduction_proxy/browser/data_reduction_proxy_protocol.cc
+++ b/components/data_reduction_proxy/browser/data_reduction_proxy_protocol.cc
@@ -36,6 +36,7 @@ namespace data_reduction_proxy {
 
 bool MaybeBypassProxyAndPrepareToRetry(
     const DataReductionProxyParams* data_reduction_proxy_params,
+    DataReductionProxyUsageStats* usage_stats,
     net::URLRequest* request,
     const net::HttpResponseHeaders* original_response_headers,
     scoped_refptr<net::HttpResponseHeaders>* override_response_headers) {
@@ -57,8 +58,9 @@ bool MaybeBypassProxyAndPrepareToRetry(
 
   DataReductionProxyInfo data_reduction_proxy_info;
   net::ProxyService::DataReductionProxyBypassType bypass_type =
-      GetDataReductionProxyBypassType(
-          original_response_headers, &data_reduction_proxy_info);
+      GetDataReductionProxyBypassType(original_response_headers,
+                                      &data_reduction_proxy_info);
+  usage_stats->SetBypassType(bypass_type);

[bengr, 2014/07/12 00:11:59]

I would move this outside of MaybeBypassProxyAndPrepareToRetry:

bool foo = MaybeBypassProxyAndPrepareToRetry(...)
usage->states(foo);

[megjablon, 2014/07/14 19:06:41]

Done.

   if (bypass_type == net::ProxyService::BYPASS_EVENT_TYPE_MAX) {
     return false;
   }