Bypassed Bytes UMAs

components/data_reduction_proxy/browser/data_reduction_proxy_params.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_DATA_REDUCTION_PROXY_BROWSER_DATA_REDUCTION_PROXY_PARAMS_H_
 #define COMPONENTS_DATA_REDUCTION_PROXY_BROWSER_DATA_REDUCTION_PROXY_PARAMS_H_
 
 #include <string>
 #include <utility>
 #include <vector>
 
 #include "base/macros.h"
 #include "net/base/host_port_pair.h"
+#include "net/proxy/proxy_retry_info.h"

[bengr, 2014/07/21 22:23:57]

You should be able to forward declare ProxyRetryInfoMap instead of including it.

 #include "url/gurl.h"
 
 namespace net {
 class URLRequest;
 }
 
 namespace data_reduction_proxy {
 // Provides initialization parameters. Proxy origins, and the probe url are
 // are taken from flags if available and from preprocessor constants otherwise.
 // The DataReductionProxySettings class and others use this class to determine
@@ skipping 61 matching lines @@
   // bypassed, if one exists. |proxy_servers| can be NULL if the caller isn't
   // interested in its values. Virtual for testing.
   virtual bool IsDataReductionProxy(const net::HostPortPair& host_port_pair,
                                     std::pair<GURL, GURL>* proxy_servers) const;
 
   // Returns true if this request will be sent through the data request proxy
   // based on applying the param rules to the URL. We do not check bad proxy
   // list.
   virtual bool IsDataReductionProxyEligible(const net::URLRequest* request);
 
+  // Checks if all configured data reduction proxies are in the retry map.
+  // Returns true if the request is bypassed by all configured data reduction
+  // proxies and returns the bypass delay in delay_seconds (if not NULL). If
+  // there are no configured data reduction proxies, returns false. If
+  // the request is bypassed by more than one proxy, delay_seconds returns
+  // the shortest delay.
+  bool AreDataReductionProxiesBypassed(const net::URLRequest& request,
+                                       base::TimeDelta* delay_seconds) const;

[bengr, 2014/07/21 22:23:57]

add:

namespace base {
class TimeDelta;
}

[megjablon, 2014/07/22 02:11:30]

Done.

+
+  // Checks if all configured data reduction proxies are in the retry map.
+  // Returns true if the request is bypassed by all configured data reduction
+  // proxies and returns the bypass delay in delay_seconds (if not NULL). If
+  // there are no configured data reduction proxies, returns false. If
+  // the request is bypassed by more than one proxy, delay_seconds returns
+  // the shortest delay.
+  bool AreProxiesBypassed(const net::ProxyRetryInfoMap& retry_map,
+                          bool ssl,
+                          base::TimeDelta* delay_second) const;
+
   // Returns the data reduction proxy primary origin.
   const GURL& origin() const {
     return origin_;
   }
 
   // Returns the data reduction proxy fallback origin.
   const GURL& fallback_origin() const {
     return fallback_origin_;
   }
 
@@ skipping 89 matching lines @@
   GURL probe_url_;
   GURL warmup_url_;
 
   bool allowed_;
   const bool fallback_allowed_;
   bool alt_allowed_;
   const bool promo_allowed_;
 
   bool configured_on_command_line_;
 
+  bool ArePrimaryAndFallbackBypassed(const net::ProxyRetryInfoMap& retry_map,

[bengr, 2014/07/21 22:23:57]

Move this up to before the member variables. Add a comment describing what it
does. All functions that are not completely obvious should have comments
describing what they do. (I know Chromium has lots of examples of functions
without comments.)

[megjablon, 2014/07/22 02:11:30]

Done.

+                                     const GURL& primary,
+                                     const GURL& fallback,
+                                     base::TimeDelta* delay_seconds) const;
+
   DISALLOW_COPY_AND_ASSIGN(DataReductionProxyParams);
 };
 
 }  // namespace data_reduction_proxy
 #endif  // COMPONENTS_DATA_REDUCTION_PROXY_BROWSER_DATA_REDUCTION_PROXY_PARAMS_H_