Bypassed Bytes UMAs

components/data_reduction_proxy/browser/data_reduction_proxy_params.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/data_reduction_proxy/browser/data_reduction_proxy_params.h"
 
 #include "base/command_line.h"
 #include "base/metrics/field_trial.h"

[bengr, 2014/07/21 22:23:56]

#include "base/time/time.h"

[megjablon, 2014/07/22 02:11:30]

Done.

 #include "components/data_reduction_proxy/common/data_reduction_proxy_switches.h"
 #include "net/proxy/proxy_info.h"
+#include "net/proxy/proxy_retry_info.h"
 #include "net/proxy/proxy_service.h"
 #include "net/url_request/url_request.h"
 #include "net/url_request/url_request_context.h"
 
 using base::FieldTrialList;
 
 namespace {
 const char kEnabled[] = "Enabled";
 }
 
@@ skipping 133 matching lines @@
   }
   if (promo_allowed_ && !allowed_) {
     DVLOG(1) << "The data reduction proxy promo cannot be allowed if the "
         << "data reduction proxy is not allowed";
     return false;
   }
   return true;
 
 }
 
-
 void DataReductionProxyParams::InitWithoutChecks() {
   const CommandLine& command_line = *CommandLine::ForCurrentProcess();
   std::string origin;
   if (!command_line.HasSwitch(switches::kDisableDataReductionProxyDev)) {
       origin = command_line.GetSwitchValueASCII(
           switches::kDataReductionProxyDev);
   }
   if (origin.empty())
     origin = command_line.GetSwitchValueASCII(switches::kDataReductionProxy);
   std::string fallback_origin =
@@ skipping 147 matching lines @@
     return std::string();
   if (command_line.HasSwitch(switches::kEnableDataReductionProxyDev) ||
       (FieldTrialList::FindFullName("DataCompressionProxyDevRollout") ==
          kEnabled)) {
     return DATA_REDUCTION_DEV_HOST;
   }
 #endif
   return std::string();
 }
 
+bool DataReductionProxyParams::AreDataReductionProxiesBypassed(
+    const net::URLRequest& request, base::TimeDelta* delay_seconds) const {
+  DCHECK(request.context());
+  if (request.context() == NULL ||
+      request.context()->proxy_service() == NULL) {
+    return AreProxiesBypassed(
+        request.context()->proxy_service()->proxy_retry_info(),
+        request.url().SchemeIs(url::kHttpsScheme),
+        delay_seconds);
+  }
+
+  return false;
+}
+
+bool DataReductionProxyParams::AreProxiesBypassed(
+    const net::ProxyRetryInfoMap& retry_map,
+    bool is_https,
+    base::TimeDelta* delay_seconds) const {
+  if (retry_map.size() == 0)
+    return false;
+
+  if (is_https && alt_allowed_) {
+    if (ArePrimaryAndFallbackBypassed(
+        retry_map, ssl_origin_, GURL(), delay_seconds)) {
+      return true;
+    }
+  } else {
+    if (allowed_) {
+      if (ArePrimaryAndFallbackBypassed(retry_map,

[bengr, 2014/07/21 22:23:57]

Here and below you can probably fit all parameters on one line.

[megjablon, 2014/07/22 02:11:29]

Done.

+                                        origin_,
+                                        fallback_origin_,
+                                        delay_seconds)) {
+        return true;
+      }
+    }
+
+    if (alt_allowed_) {
+      if (ArePrimaryAndFallbackBypassed(retry_map,
+                                        alt_origin_,
+                                        alt_fallback_origin_,
+                                        delay_seconds)) {
+        return true;
+      }
+    }
+  }
+
+  return false;
+}
+
+bool DataReductionProxyParams::ArePrimaryAndFallbackBypassed(
+    const net::ProxyRetryInfoMap& retry_map,
+    const GURL& primary,
+    const GURL& fallback,
+    base::TimeDelta* delay_seconds) const {

[bengr, 2014/07/21 22:23:57]

This is no longer in seconds and it otherwise vague. It should be called
minimum_retry_delay, or something like that.

[megjablon, 2014/07/22 02:11:29]

Done.

+  base::TimeDelta shortest_delay;
+  net::ProxyRetryInfoMap::const_iterator found;
+
+  found = retry_map.find(
+      net::ProxyServer(primary.SchemeIs(url::kHttpsScheme) ?
+          net::ProxyServer::SCHEME_HTTPS : net::ProxyServer::SCHEME_HTTP,

[bengr, 2014/07/21 22:23:56]

#include "net/proxy/proxy_server.h"

[megjablon, 2014/07/22 02:11:29]

Done.

+          net::HostPortPair::FromURL(primary)).ToURI());
+  if (!(found == retry_map.end())) {
+    shortest_delay = found->second.current_delay;

[bengr, 2014/07/21 22:23:57]

There are only two possible delays, so this should be "shorter_delay" right?
(Sorry, I've been influenced by Weird Al's Word Crimes.)

[megjablon, 2014/07/22 02:11:30]

Done.

+    if (fallback_allowed_ && fallback.is_valid()) {
+      found = retry_map.find(
+          net::ProxyServer(fallback.SchemeIs(url::kHttpsScheme) ?

[bengr, 2014/07/21 22:23:57]

#include "url/url_constants.h"

[megjablon, 2014/07/22 02:11:29]

Done.

+              net::ProxyServer::SCHEME_HTTPS : net::ProxyServer::SCHEME_HTTP,
+              net::HostPortPair::FromURL(fallback)).ToURI());

[bengr, 2014/07/21 22:23:56]

#include "net/base/host_port_pair.h"

[megjablon, 2014/07/22 02:11:30]

Done.

+      if (!(found == retry_map.end())) {
+        if(shortest_delay > found->second.current_delay)
+          shortest_delay = found->second.current_delay;
+        if (delay_seconds != NULL)
+          *delay_seconds = shortest_delay;
+        return true;
+      }
+    } else {
+      if (delay_seconds != NULL)
+        *delay_seconds = shortest_delay;
+      return true;
+    }
+  }
+
+  return false;
+}
+
 std::string DataReductionProxyParams::GetDefaultOrigin() const {
 #if defined(SPDY_PROXY_AUTH_ORIGIN)
   return SPDY_PROXY_AUTH_ORIGIN;
 #endif
   return std::string();
 }
 
 std::string DataReductionProxyParams::GetDefaultFallbackOrigin() const {
 #if defined(DATA_REDUCTION_FALLBACK_HOST)
   return DATA_REDUCTION_FALLBACK_HOST;
@@ skipping 30 matching lines @@
 }
 
 std::string DataReductionProxyParams::GetDefaultWarmupURL() const {
 #if defined(DATA_REDUCTION_PROXY_WARMUP_URL)
   return DATA_REDUCTION_PROXY_WARMUP_URL;
 #endif
   return std::string();
 }
 
 }  // namespace data_reduction_proxy