Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 390533002: Subzero: Fix the name mangling code's base-36 increment. (Closed)

Created:
6 years, 5 months ago by Jim Stichnoth
Modified:
6 years, 5 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://gerrit.chromium.org/gerrit/p/native_client/pnacl-subzero.git@master
Visibility:
Public.

Description

Subzero: Fix the name mangling code's base-36 increment. SZZZ_ was being incremented to S0000_ instead of S1000_. BUG= https://codereview.chromium.org/385273002/ R=wala@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=78b4c0b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M src/IceGlobalContext.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M tests_lit/llvm2ice_tests/mangle.ll View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jim Stichnoth
6 years, 5 months ago (2014-07-11 22:07:27 UTC) #1
wala
On 2014/07/11 22:07:27, stichnot wrote: lgtm
6 years, 5 months ago (2014-07-11 22:29:04 UTC) #2
Jim Stichnoth
6 years, 5 months ago (2014-07-11 22:29:26 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r78b4c0b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698