Adding last_forced column to thumbnails database.

Adding last_forced column to thumbnails database.

The last_forced column will eventually make it possible for TopSites to indicate URLs for which thumbnails must be captured. Such URLs can come from an external source of NTP suggestions. Keeping the time makes it possible to evict forced thumbnails in a LRU fashion.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231648

[beaudoin, 2013-10-24 18:37:52]

Scott, Brett,

Following the email discussion we had on ways to force URLs to be captured by
TopSites, here's a proposal of a change to the database that would allow this.

[beaudoin, 2013-10-25 16:13:34]

On 2013/10/24 18:37:52, beaudoin wrote:
> Scott, Brett,
> 
> Following the email discussion we had on ways to force URLs to be captured by
> TopSites, here's a proposal of a change to the database that would allow this.

Hi Scott, Brett,

I've added a couple of tests to check ranking and forcing TopSites URLs works
correctly with the database. Next I'll be working on TopSites itself but I'd
really like you to validate the approach I've taken here.

Thanks!

[brettw, 2013-10-28 22:22:27]

lgtm

https://codereview.chromium.org/39053005/diff/260001/chrome/browser/history/h...
File chrome/browser/history/history_types.h (right):

https://codereview.chromium.org/39053005/diff/260001/chrome/browser/history/h...
chrome/browser/history/history_types.h:521: // time it was forced. If it's not a
forced thumbnail, keep a time of 0.
It would be nice if this mentioned why we store this (so we can evict at some
point). Otherwise this seems pretty mysterious.

https://codereview.chromium.org/39053005/diff/260001/chrome/browser/history/t...
File chrome/browser/history/top_sites_database.cc (right):

https://codereview.chromium.org/39053005/diff/260001/chrome/browser/history/t...
chrome/browser/history/top_sites_database.cc:288: << "Thumbnail without a forced
time stamp has a forced rank, or the "
Nit: intend 2 more spaces.

https://codereview.chromium.org/39053005/diff/260001/chrome/browser/history/t...
chrome/browser/history/top_sites_database.cc:303: << "Thumbnail without a forced
time stamp has a forced rank, or the "
ditto

https://codereview.chromium.org/39053005/diff/260001/chrome/browser/history/t...
File chrome/browser/history/top_sites_database.h (right):

https://codereview.chromium.org/39053005/diff/260001/chrome/browser/history/t...
chrome/browser/history/top_sites_database.h:98: // Returns |url|'s current rank
or RANK_OF_NONEXISTING_URL if not present.
Update this to match constant.

[beaudoin, 2013-10-29 15:27:50]

Submitting...

https://codereview.chromium.org/39053005/diff/260001/chrome/browser/history/h...
File chrome/browser/history/history_types.h (right):

https://codereview.chromium.org/39053005/diff/260001/chrome/browser/history/h...
chrome/browser/history/history_types.h:521: // time it was forced. If it's not a
forced thumbnail, keep a time of 0.
On 2013/10/28 22:22:27, brettw wrote:
> It would be nice if this mentioned why we store this (so we can evict at some
> point). Otherwise this seems pretty mysterious.

Done.

https://codereview.chromium.org/39053005/diff/260001/chrome/browser/history/t...
File chrome/browser/history/top_sites_database.cc (right):

https://codereview.chromium.org/39053005/diff/260001/chrome/browser/history/t...
chrome/browser/history/top_sites_database.cc:288: << "Thumbnail without a forced
time stamp has a forced rank, or the "
On 2013/10/28 22:22:27, brettw wrote:
> Nit: intend 2 more spaces.

Done.

https://codereview.chromium.org/39053005/diff/260001/chrome/browser/history/t...
chrome/browser/history/top_sites_database.cc:303: << "Thumbnail without a forced
time stamp has a forced rank, or the "
On 2013/10/28 22:22:27, brettw wrote:
> ditto

Done.

https://codereview.chromium.org/39053005/diff/260001/chrome/browser/history/t...
File chrome/browser/history/top_sites_database.h (right):

https://codereview.chromium.org/39053005/diff/260001/chrome/browser/history/t...
chrome/browser/history/top_sites_database.h:98: // Returns |url|'s current rank
or RANK_OF_NONEXISTING_URL if not present.
On 2013/10/28 22:22:27, brettw wrote:
> Update this to match constant.

Done.

[commit-bot: I haz the power, 2013-10-29 15:30:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/beaudoin@chromium.org/39053005/330001

[commit-bot: I haz the power, 2013-10-29 18:34:32]

Retried try job too often on win_rel for step(s) content_unittests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-10-29 19:10:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/beaudoin@chromium.org/39053005/330001

[commit-bot: I haz the power, 2013-10-29 21:58:26]

Change committed as 231648