Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 390513002: [chromedriver] Hardcode mobile devices list. (Closed)

Created:
6 years, 5 months ago by samuong
Modified:
6 years, 5 months ago
Reviewers:
stgao
CC:
chromium-reviews, stgao
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[chromedriver] Hardcode mobile devices list. Previously chromedriver generated the mobile devices list from OverridesUI.js in Blink, however changes introduced in Blink revision 177868 break our tests. I'm hardcoding the value of our mobile devices list to what is was prior to this Blink change, until we implement a new way to generate the list. BUG=392430 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283354

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -21 lines) Patch
M chrome/chrome_tests.gypi View 3 chunks +2 lines, -21 lines 0 comments Download
A chrome/test/chromedriver/chrome/mobile_device_list.h View 1 chunk +10 lines, -0 lines 0 comments Download
A chrome/test/chromedriver/chrome/mobile_device_list.cc View 1 chunk +114 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
samuong
6 years, 5 months ago (2014-07-11 19:37:53 UTC) #1
samuong
The CQ bit was checked by samuong@chromium.org
6 years, 5 months ago (2014-07-11 19:37:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/samuong@chromium.org/390513002/1
6 years, 5 months ago (2014-07-11 19:40:31 UTC) #3
stgao
The CQ bit was unchecked by stgao@chromium.org
6 years, 5 months ago (2014-07-11 19:52:20 UTC) #4
stgao
Let's discuss this a little bit before committing this CL. We'd better talk with DevTools ...
6 years, 5 months ago (2014-07-11 19:54:27 UTC) #5
samuong
The CQ bit was checked by samuong@chromium.org
6 years, 5 months ago (2014-07-15 17:48:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/samuong@chromium.org/390513002/1
6 years, 5 months ago (2014-07-15 17:52:44 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-15 18:46:18 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 05:20:42 UTC) #9
Message was sent while issue was closed.
Change committed as 283354

Powered by Google App Engine
This is Rietveld 408576698