Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7962)

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller_private.h

Issue 390503003: Enables permission bubbles to remain visible during fulscreen on Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: removed alwaysShowDropdown Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser_window_controller_private.h
diff --git a/chrome/browser/ui/cocoa/browser_window_controller_private.h b/chrome/browser/ui/cocoa/browser_window_controller_private.h
index f0a4a3dd8fe5ec26a5872459ba641f26aa1c600f..692324620749f229a2787bb1dc685ba0536e2109 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller_private.h
+++ b/chrome/browser/ui/cocoa/browser_window_controller_private.h
@@ -104,6 +104,11 @@
regularWindow:(NSWindow*)regularWindow
fullscreenWindow:(NSWindow*)fullscreenWindow;
+// Called when a permission bubble closes. Needed to changes fullscreen mode to
+// allow the floating bar to be hidden once there is no permission bubble
Robert Sesek 2014/07/14 20:22:31 This sentence is awkward to read.
leng 2014/07/14 21:28:32 Edited; hopefully better.
Robert Sesek 2014/07/15 16:38:16 Yes, much.
+// requiring the bar to remain visible.
+- (void)permissionBubbleWindowWillClose:(NSNotification*)notification;
+
// Sets presentation mode, creating the PresentationModeController if needed and
// forcing a relayout. If |forceDropdown| is YES, this method will always
// initially show the floating bar when entering presentation mode, even if the
@@ -133,6 +138,10 @@
- (void)enableBarVisibilityUpdates;
- (void)disableBarVisibilityUpdates;
+// If there are no visibility locks and bar visibity updates are enabled, hides
+// the bar with |animation| and |delay|. Otherwise, does nothing.
+- (void)hideOverlayIfPossibleWithAnimation:(BOOL)animation delay:(BOOL)delay;
+
// The opacity for the toolbar divider; 0 means that it shouldn't be shown.
- (CGFloat)toolbarDividerOpacity;

Powered by Google App Engine
This is Rietveld 408576698