Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 390483002: nanobench: add a cute bar chart (Closed)

Created:
6 years, 5 months ago by mtklein_C
Modified:
6 years, 5 months ago
Reviewers:
krajcevski, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

nanobench: add a cute bar chart Give this a try? Helpful, or gets in the way? BUG=skia: Committed: https://skia.googlesource.com/skia/+/5d9d10e8217d2138b5514a4d4216f95373240942

Patch Set 1 #

Patch Set 2 : size_t #

Patch Set 3 : size_t >= 0, duh #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -4 lines) Patch
M bench/nanobench.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M tools/Stats.h View 1 2 2 chunks +19 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
mtklein_C
6 years, 5 months ago (2014-07-11 15:54:00 UTC) #1
krajcevski
On 2014/07/11 15:54:00, mtklein_C wrote: lgtm, although a bit gimmicky. Aren't you worried about build ...
6 years, 5 months ago (2014-07-11 17:59:00 UTC) #2
mtklein
On 2014/07/11 17:59:00, krajcevski wrote: > On 2014/07/11 15:54:00, mtklein_C wrote: > > lgtm, although ...
6 years, 5 months ago (2014-07-11 18:00:33 UTC) #3
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 5 months ago (2014-07-11 18:00:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/390483002/1
6 years, 5 months ago (2014-07-11 18:01:01 UTC) #5
mtklein_C
The CQ bit was checked by mtklein@chromium.org
6 years, 5 months ago (2014-07-11 18:16:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/390483002/20001
6 years, 5 months ago (2014-07-11 18:18:01 UTC) #7
mtklein_C
The CQ bit was checked by mtklein@chromium.org
6 years, 5 months ago (2014-07-11 18:32:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/390483002/40001
6 years, 5 months ago (2014-07-11 18:33:00 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-11 18:57:12 UTC) #10
Message was sent while issue was closed.
Change committed as 5d9d10e8217d2138b5514a4d4216f95373240942

Powered by Google App Engine
This is Rietveld 408576698