Move files instead of copying them.

Move files instead of copying them.

BUG=1184319, 8218

[kuchhal, 2009-03-03 20:56:03]

Before this change the install was taking around 15-18 seconds on my machine.
After this change it consistently takes less than 6 seconds for install. These
numbers are for full installer. I am guessing differential installer will take
slightly more but still should be much faster.

[huanr, 2009-03-04 07:17:28]

I am wondering about the following two cases:
(1) the source is in use.
(2) the source and dest are in different disk volumn.
It seems both cases are not relevant in install path, in addition the current
move_tree implementation may work even in the above two cases, but I just like
to double check.

It would be nice to add a test case for source in use.

http://codereview.chromium.org/39048/diff/1/4
File chrome/installer/util/move_tree_work_item.cc (right):

http://codereview.chromium.org/39048/diff/1/4#newcode69
Line 69: bool MoveTreeWorkItem::GetBackupPath() {
CreateBackupPath could be a better name. GetBackupPath sounds like we can call
it multiple times and get the same path.

[kuchhal, 2009-03-04 19:38:46]

- Added a test case for when source is in use
- If destination is on a different volume it will end up using nearly the same
time as copy so we will not be any worse off.
- Got rid of GetBackupPath as it really didnt need to be a separate function.

[huanr, 2009-03-04 19:45:38]

LGTM

http://codereview.chromium.org/39048/diff/1002/29
File chrome/installer/util/util.vcproj (right):

http://codereview.chromium.org/39048/diff/1002/29#newcode231
Line 231: <File
Is this intended in this CL? Same question for change below.

[cpu_(ooo_6.6-7.5), 2009-03-04 20:06:26]

LGTM with the comment below. Thanks for doing this.

http://codereview.chromium.org/39048/diff/1002/26
File chrome/installer/util/move_tree_work_item.cc (right):

http://codereview.chromium.org/39048/diff/1002/26#newcode17
Line 17: MoveTreeWorkItem::MoveTreeWorkItem(std::wstring source_path,
definitely this should be pass by reference

http://codereview.chromium.org/39048/diff/1002/27
File chrome/installer/util/move_tree_work_item.h (right):

http://codereview.chromium.org/39048/diff/1002/27#newcode36
Line 36: MoveTreeWorkItem(std::wstring source_path,
why pass by copy?