Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1032)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 390393002: Fix GMOCK warnings in PasswordManagerTest (Closed)

Created:
6 years, 5 months ago by Jiang Jiang
Modified:
6 years, 5 months ago
Reviewers:
Garrett Casto
CC:
chromium-reviews, gcasto+watchlist_chromium.org, mkwst+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix GMOCK warnings in PasswordManagerTest Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283933

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 2

Patch Set 3 : Rebase #

Patch Set 4 : Move to SetUp() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M components/password_manager/core/browser/password_manager_unittest.cc View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Jiang Jiang
6 years, 5 months ago (2014-07-16 16:19:46 UTC) #1
Garrett Casto
https://codereview.chromium.org/390393002/diff/20001/components/password_manager/core/browser/password_manager_unittest.cc File components/password_manager/core/browser/password_manager_unittest.cc (right): https://codereview.chromium.org/390393002/diff/20001/components/password_manager/core/browser/password_manager_unittest.cc#newcode227 components/password_manager/core/browser/password_manager_unittest.cc:227: .WillRepeatedly(Return(false)); Just do this once in SetUp() and we ...
6 years, 5 months ago (2014-07-16 18:45:50 UTC) #2
Jiang Jiang
https://codereview.chromium.org/390393002/diff/20001/components/password_manager/core/browser/password_manager_unittest.cc File components/password_manager/core/browser/password_manager_unittest.cc (right): https://codereview.chromium.org/390393002/diff/20001/components/password_manager/core/browser/password_manager_unittest.cc#newcode227 components/password_manager/core/browser/password_manager_unittest.cc:227: .WillRepeatedly(Return(false)); On 2014/07/16 18:45:50, Garrett Casto wrote: > Just ...
6 years, 5 months ago (2014-07-17 12:27:49 UTC) #3
Jiang Jiang
Ping, can you take another look?
6 years, 5 months ago (2014-07-17 19:07:21 UTC) #4
Garrett Casto
lgtm
6 years, 5 months ago (2014-07-17 20:03:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jiangj@opera.com/390393002/60001
6 years, 5 months ago (2014-07-17 20:06:19 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 23:59:39 UTC) #7
Message was sent while issue was closed. 
Change committed as 283933

Powered by Google App Engine
This is Rietveld 408576698