Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 390363002: Unprefix most methods on FullscreenElementStack (Closed)

Created:
6 years, 5 months ago by philipj_slow
Modified:
6 years, 5 months ago
CC:
arv+blink, blink-reviews, blink-reviews-dom_chromium.org, Inactive, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Project:
blink
Visibility:
Public.

Description

Unprefix most methods on FullscreenElementStack fullscreenEnabled no longer even considers the webkitallowfullscreen attribute, and the prefixes do no good internally anyway. They are left only on the Mozilla-style API since they should generally not be used other than for bindings. It turned out that the Internals wrappers were unused. They were added in http://trac.webkit.org/changeset/114790 "to facilitate writing reproducible LayoutTests", but no tests using them were ever added. BUG=383813 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178339

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -60 lines) Patch
M Source/core/dom/DocumentFullscreen.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/FullscreenElementStack.h View 2 chunks +7 lines, -8 lines 0 comments Download
M Source/core/dom/FullscreenElementStack.cpp View 7 chunks +8 lines, -8 lines 0 comments Download
M Source/core/testing/Internals.h View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/testing/Internals.cpp View 1 chunk +0 lines, -28 lines 0 comments Download
M Source/core/testing/Internals.idl View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/web/FullscreenController.cpp View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
philipj_slow
PTAL. I'd like to land this before the Web-facing unprefixing so that the most likely ...
6 years, 5 months ago (2014-07-15 12:09:03 UTC) #1
falken
lgtm nit: rietveld breaks the link in your CL Description, maybe delete the semicolon?
6 years, 5 months ago (2014-07-17 02:28:18 UTC) #2
philipj_slow
On 2014/07/17 02:28:18, falken wrote: > lgtm > > nit: rietveld breaks the link in ...
6 years, 5 months ago (2014-07-17 06:12:00 UTC) #3
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 5 months ago (2014-07-17 06:12:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/390363002/1
6 years, 5 months ago (2014-07-17 06:13:50 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 5 months ago (2014-07-17 06:17:38 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-17 06:20:57 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/10383)
6 years, 5 months ago (2014-07-17 06:20:58 UTC) #8
philipj_slow
Jochen, can you review Source/web for me? Thanks!
6 years, 5 months ago (2014-07-17 06:38:08 UTC) #9
jochen (gone - plz use gerrit)
lgtm
6 years, 5 months ago (2014-07-17 07:04:17 UTC) #10
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 5 months ago (2014-07-17 07:33:13 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/390363002/1
6 years, 5 months ago (2014-07-17 07:34:26 UTC) #12
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 08:43:56 UTC) #13
Message was sent while issue was closed.
Change committed as 178339

Powered by Google App Engine
This is Rietveld 408576698