Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 390353002: Fix assertion failure. Use Vector instead of List in code deserializer. (Closed)

Created:
6 years, 5 months ago by Yang
Modified:
6 years, 5 months ago
Reviewers:
mvstanton
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Fix assertion failure. Use Vector instead of List in code deserializer. R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22407

Patch Set 1 #

Patch Set 2 : move dispose to the destructor of Deserializer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M src/serialize.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/serialize.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
6 years, 5 months ago (2014-07-15 10:53:21 UTC) #1
mvstanton
lgtm
6 years, 5 months ago (2014-07-15 11:00:49 UTC) #2
Yang
6 years, 5 months ago (2014-07-15 11:01:10 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r22407 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698