Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 39033006: Add tests for legacy SDP features. (Closed)

Created:
7 years, 1 month ago by bemasc
Modified:
7 years, 1 month ago
CC:
chromium-reviews, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://src.chromium.org/chrome/trunk/src/
Visibility:
Public.

Description

Add tests for legacy SDP features. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232259

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 12

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -14 lines) Patch
M content/browser/media/webrtc_browsertest.cc View 1 2 3 1 chunk +22 lines, -0 lines 0 comments Download
M content/test/data/media/peerconnection-call.html View 1 2 3 5 chunks +84 lines, -14 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
bemasc
7 years, 1 month ago (2013-10-24 21:08:23 UTC) #1
bemasc
Oops, trybots found a bug. Investigating...
7 years, 1 month ago (2013-10-24 22:59:12 UTC) #2
bemasc
On 2013/10/24 22:59:12, bemasc wrote: > Oops, trybots found a bug. Investigating... Fixed.
7 years, 1 month ago (2013-10-24 23:12:39 UTC) #3
phoglund_chromium
https://codereview.chromium.org/39033006/diff/260002/content/browser/media/webrtc_browsertest.cc File content/browser/media/webrtc_browsertest.cc (right): https://codereview.chromium.org/39033006/diff/260002/content/browser/media/webrtc_browsertest.cc#newcode246 content/browser/media/webrtc_browsertest.cc:246: #endif Nit: insert blank line here. https://codereview.chromium.org/39033006/diff/260002/content/test/data/media/peerconnection-call.html File content/test/data/media/peerconnection-call.html ...
7 years, 1 month ago (2013-10-25 00:45:05 UTC) #4
bemasc
https://codereview.chromium.org/39033006/diff/260002/content/test/data/media/peerconnection-call.html File content/test/data/media/peerconnection-call.html (right): https://codereview.chromium.org/39033006/diff/260002/content/test/data/media/peerconnection-call.html#newcode515 content/test/data/media/peerconnection-call.html:515: if (gTestWithoutMsid) { On 2013/10/25 00:45:05, phoglund wrote: > ...
7 years, 1 month ago (2013-10-25 00:53:52 UTC) #5
phoglund_chromium
https://codereview.chromium.org/39033006/diff/260002/content/test/data/media/peerconnection-call.html File content/test/data/media/peerconnection-call.html (right): https://codereview.chromium.org/39033006/diff/260002/content/test/data/media/peerconnection-call.html#newcode515 content/test/data/media/peerconnection-call.html:515: if (gTestWithoutMsid) { Oh, ok. Perhaps we can consider ...
7 years, 1 month ago (2013-10-25 01:15:59 UTC) #6
bemasc
https://codereview.chromium.org/39033006/diff/260002/content/browser/media/webrtc_browsertest.cc File content/browser/media/webrtc_browsertest.cc (right): https://codereview.chromium.org/39033006/diff/260002/content/browser/media/webrtc_browsertest.cc#newcode246 content/browser/media/webrtc_browsertest.cc:246: #endif On 2013/10/25 00:45:05, phoglund wrote: > Nit: insert ...
7 years, 1 month ago (2013-10-25 17:39:55 UTC) #7
phoglund_chromium
lgtm
7 years, 1 month ago (2013-10-25 20:39:45 UTC) #8
phoglund_chromium
Oh, and I'm not an owner so you need an owner stamp from xians@ or ...
7 years, 1 month ago (2013-10-31 16:29:21 UTC) #9
no longer working on chromium
rubber stamp lgtm
7 years, 1 month ago (2013-10-31 16:51:59 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bemasc@chromium.org/39033006/350001
7 years, 1 month ago (2013-10-31 17:59:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bemasc@chromium.org/39033006/350001
7 years, 1 month ago (2013-10-31 23:16:41 UTC) #12
commit-bot: I haz the power
7 years, 1 month ago (2013-11-01 01:11:07 UTC) #13
Message was sent while issue was closed.
Change committed as 232259

Powered by Google App Engine
This is Rietveld 408576698