Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 390303002: Do not dump user source code in the code serializer. (Closed)

Created:
6 years, 5 months ago by Yang
Modified:
6 years, 5 months ago
Reviewers:
mvstanton
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Do not dump user source code in the code serializer. R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22403

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -41 lines) Patch
M src/assembler.h View 1 chunk +0 lines, -11 lines 0 comments Download
M src/compiler.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/serialize.h View 4 chunks +33 lines, -11 lines 0 comments Download
M src/serialize.cc View 8 chunks +52 lines, -16 lines 0 comments Download
M test/cctest/test-serialize.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
6 years, 5 months ago (2014-07-15 09:11:34 UTC) #1
mvstanton
Good stuff. LGTM.
6 years, 5 months ago (2014-07-15 09:29:21 UTC) #2
Yang
6 years, 5 months ago (2014-07-15 10:17:34 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22403 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698