Uninstall default apps if user hides promo

Uninstall default apps if user hides promo
We now uninstall the default apps if the user hides the NTP app promo. This only happens if the user hasn't already installed other apps.

BUG=59453
TEST=DefaultApps. Also, clicking the 'Hide this' message on the app promo should uninstall the default apps.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=63242

[Aaron Boodman, 2010-10-19 22:22:48]

lgtm w/ nit

[Aaron Boodman, 2010-10-19 22:45:11]

http://codereview.chromium.org/3903002/diff/1/3
File chrome/browser/dom_ui/app_launcher_handler.cc (right):

http://codereview.chromium.org/3903002/diff/1/3#newcode273
chrome/browser/dom_ui/app_launcher_handler.cc:273: // this point, or the
promotion wouldn't have been shown).
It might be good to DCHECK that, just to self-document.

[jstritar, 2010-10-20 15:26:54]

Sounds good. I added a DCHECK that verifies the default app id list is equal to
the installed app id list.

On 2010/10/19 22:45:11, Aaron Boodman wrote:
> http://codereview.chromium.org/3903002/diff/1/3
> File chrome/browser/dom_ui/app_launcher_handler.cc (right):
> 
> http://codereview.chromium.org/3903002/diff/1/3#newcode273
> chrome/browser/dom_ui/app_launcher_handler.cc:273: // this point, or the
> promotion wouldn't have been shown).
> It might be good to DCHECK that, just to self-document.

[Aaron Boodman, 2010-10-20 15:41:50]

Still LGTM