[SyncFS] Demote local file changes before local-to-remote sync (3/3)

[SyncFS] Demote local file changes before local-to-remote sync

This prevents a task to pick a file to sync while another task is syncing it.

BUG=344769
TEST=unit_tests --gtest_filter='LocalFileSyncContextTest.*'

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287312

[tzik, 2014-07-15 07:07:23]

PTL

[peria, 2014-07-15 07:19:49]

Please fill BUG line and TEST line in the description.

https://codereview.chromium.org/390283002/diff/1/chrome/browser/sync_file_sys...
File chrome/browser/sync_file_system/local/local_file_sync_context.cc (right):

https://codereview.chromium.org/390283002/diff/1/chrome/browser/sync_file_sys...
chrome/browser/sync_file_system/local/local_file_sync_context.cc:776: for
(std::deque<FileSystemURL>::iterator iter = urls->begin();
s/std::deque<FileSystemURL>/FileSystemURLQueue/ ?

[tzik, 2014-07-22 13:14:33]

Updated! PTAL.

https://codereview.chromium.org/390283002/diff/1/chrome/browser/sync_file_sys...
File chrome/browser/sync_file_system/local/local_file_sync_context.cc (right):

https://codereview.chromium.org/390283002/diff/1/chrome/browser/sync_file_sys...
chrome/browser/sync_file_system/local/local_file_sync_context.cc:776: for
(std::deque<FileSystemURL>::iterator iter = urls->begin();
On 2014/07/15 07:19:49, peria wrote:
> s/std::deque<FileSystemURL>/FileSystemURLQueue/ ?

Done.

[peria, 2014-07-23 01:54:42]

lgtm

[tzik, 2014-07-25 03:01:58]

The CQ bit was checked by tzik@chromium.org

[commit-bot: I haz the power, 2014-07-25 03:04:01]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tzik@chromium.org/390283002/120001

[commit-bot: I haz the power, 2014-07-25 07:40:38]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_rel_swarming on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_sw...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-07-25 08:20:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-25 08:20:18]

Try jobs failed on following builders:
  linux_chromium_rel_swarming on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_sw...)

[tzik, 2014-08-04 05:47:46]

The CQ bit was checked by tzik@chromium.org

[commit-bot: I haz the power, 2014-08-04 05:48:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tzik@chromium.org/390283002/180001

[commit-bot: I haz the power, 2014-08-04 09:27:46]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[commit-bot: I haz the power, 2014-08-04 09:56:23]

Change committed as 287312