Experimental app list banner now appears on top of launcher pages.

Experimental app list banner now appears on top of launcher pages.

The banner is now its own view (instead of being painted directly onto
the background), and the view paints to a layer, so that it appears on
top of other layers such as the WebContents of the custom launcher
pages.

BUG=393858
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283256

[calamity, 2014-07-15 08:57:58]

lgtm

https://codereview.chromium.org/390273002/diff/20001/ui/app_list/views/app_li...
File ui/app_list/views/app_list_view.cc (right):

https://codereview.chromium.org/390273002/diff/20001/ui/app_list/views/app_li...
ui/app_list/views/app_list_view.cc:482: contents_bounds.height() -
image_bounds.height()));
You can avoid making two calls here.

image_bounds.set_origin(
    gfx::Point(contents_bounds.width() - image_bounds.width(),
               contents_bounds.height() - image_bounds.height());
experimental_banner_view_->SetBoundsRect(image_bounds);

[Matt Giuca, 2014-07-15 09:11:31]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2014-07-15 09:12:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mgiuca@chromium.org/390273002/40001

[commit-bot: I haz the power, 2014-07-15 19:26:15]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-15 21:50:30]

Change committed as 283256

[Matt Giuca, 2014-07-16 00:18:07]

https://codereview.chromium.org/390273002/diff/20001/ui/app_list/views/app_li...
File ui/app_list/views/app_list_view.cc (right):

https://codereview.chromium.org/390273002/diff/20001/ui/app_list/views/app_li...
ui/app_list/views/app_list_view.cc:482: contents_bounds.height() -
image_bounds.height()));
On 2014/07/15 08:57:58, calamity wrote:
> You can avoid making two calls here.
> 
> image_bounds.set_origin(
>     gfx::Point(contents_bounds.width() - image_bounds.width(),
>                contents_bounds.height() - image_bounds.height());
> experimental_banner_view_->SetBoundsRect(image_bounds);

Done.