Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4080)

Unified Diff: components/policy/core/browser/configuration_policy_handler_unittest.cc

Issue 390233003: Decrement CreateDoubleValue count (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/policy/core/browser/configuration_policy_handler_unittest.cc
diff --git a/components/policy/core/browser/configuration_policy_handler_unittest.cc b/components/policy/core/browser/configuration_policy_handler_unittest.cc
index db30b0f1c51ae301ddd95ec9e23bae71f67957ee..a969219087b45efbcd3ded57a293f07aec94e1df 100644
--- a/components/policy/core/browser/configuration_policy_handler_unittest.cc
+++ b/components/policy/core/browser/configuration_policy_handler_unittest.cc
@@ -530,7 +530,7 @@ TEST(IntPercentageToDoublePolicyHandler, ApplyPolicySettingsClamp) {
NULL);
prefs.Clear();
handler.ApplyPolicySettings(policy_map, &prefs);
- expected.reset(base::Value::CreateDoubleValue(0.0));
+ expected.reset(new base::FundamentalValue(0.0));
EXPECT_TRUE(prefs.GetValue(kTestPref, &value));
EXPECT_TRUE(base::Value::Equals(expected.get(), value));
@@ -541,7 +541,7 @@ TEST(IntPercentageToDoublePolicyHandler, ApplyPolicySettingsClamp) {
NULL);
prefs.Clear();
handler.ApplyPolicySettings(policy_map, &prefs);
- expected.reset(base::Value::CreateDoubleValue(0.05));
+ expected.reset(new base::FundamentalValue(0.05));
EXPECT_TRUE(prefs.GetValue(kTestPref, &value));
EXPECT_TRUE(base::Value::Equals(expected.get(), value));
@@ -552,7 +552,7 @@ TEST(IntPercentageToDoublePolicyHandler, ApplyPolicySettingsClamp) {
NULL);
prefs.Clear();
handler.ApplyPolicySettings(policy_map, &prefs);
- expected.reset(base::Value::CreateDoubleValue(0.1));
+ expected.reset(new base::FundamentalValue(0.1));
EXPECT_TRUE(prefs.GetValue(kTestPref, &value));
EXPECT_TRUE(base::Value::Equals(expected.get(), value));
@@ -565,7 +565,7 @@ TEST(IntPercentageToDoublePolicyHandler, ApplyPolicySettingsClamp) {
NULL);
prefs.Clear();
handler.ApplyPolicySettings(policy_map, &prefs);
- expected.reset(base::Value::CreateDoubleValue(0.0));
+ expected.reset(new base::FundamentalValue(0.0));
EXPECT_TRUE(prefs.GetValue(kTestPref, &value));
EXPECT_TRUE(base::Value::Equals(expected.get(), value));
@@ -576,7 +576,7 @@ TEST(IntPercentageToDoublePolicyHandler, ApplyPolicySettingsClamp) {
NULL);
prefs.Clear();
handler.ApplyPolicySettings(policy_map, &prefs);
- expected.reset(base::Value::CreateDoubleValue(0.1));
+ expected.reset(new base::FundamentalValue(0.1));
EXPECT_TRUE(prefs.GetValue(kTestPref, &value));
EXPECT_TRUE(base::Value::Equals(expected.get(), value));
}
@@ -600,7 +600,7 @@ TEST(IntPercentageToDoublePolicyHandler, ApplyPolicySettingsDontClamp) {
NULL);
prefs.Clear();
handler.ApplyPolicySettings(policy_map, &prefs);
- expected.reset(base::Value::CreateDoubleValue(0.0));
+ expected.reset(new base::FundamentalValue(0.0));
EXPECT_TRUE(prefs.GetValue(kTestPref, &value));
EXPECT_TRUE(base::Value::Equals(expected.get(), value));
@@ -611,7 +611,7 @@ TEST(IntPercentageToDoublePolicyHandler, ApplyPolicySettingsDontClamp) {
NULL);
prefs.Clear();
handler.ApplyPolicySettings(policy_map, &prefs);
- expected.reset(base::Value::CreateDoubleValue(0.05));
+ expected.reset(new base::FundamentalValue(0.05));
EXPECT_TRUE(prefs.GetValue(kTestPref, &value));
EXPECT_TRUE(base::Value::Equals(expected.get(), value));
@@ -622,7 +622,7 @@ TEST(IntPercentageToDoublePolicyHandler, ApplyPolicySettingsDontClamp) {
NULL);
prefs.Clear();
handler.ApplyPolicySettings(policy_map, &prefs);
- expected.reset(base::Value::CreateDoubleValue(0.1));
+ expected.reset(new base::FundamentalValue(0.1));
EXPECT_TRUE(prefs.GetValue(kTestPref, &value));
EXPECT_TRUE(base::Value::Equals(expected.get(), value));
}
« no previous file with comments | « components/policy/core/browser/configuration_policy_handler.cc ('k') | components/policy/core/common/mac_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698