Decrement CreateDoubleValue count

base/prefs/pref_value_map.h

Index: base/prefs/pref_value_map.h
diff --git a/base/prefs/pref_value_map.h b/base/prefs/pref_value_map.h
index 1d7912771967f64b09747e794facce2aa8fe907e..2db18ab2a187144ee834388afe550702c5d8c9b4 100644
--- a/base/prefs/pref_value_map.h
+++ b/base/prefs/pref_value_map.h
@@ -71,6 +71,9 @@ class BASE_PREFS_EXPORT PrefValueMap {
   // Sets the value for |key| to the int |value|.
   void SetInteger(const std::string& key, const int value);
 
+  // Sets the value for |key| to the double |value|.
+  void SetDouble(const std::string& key, const double value);

[battre, 2014/07/16 07:37:12]

Can you add a GetDouble as well so that we have full symmetry?

[Evan Stade, 2014/07/16 22:15:25]

I don't think it's a good idea to add dead code.

[battre, 2014/07/17 15:58:39]

I'll leave it up to you but feel that you are pushing the burden to get another
owner's approval to the next person who will wonder why everything has a getter
and setter except for double.

[Evan Stade, 2014/07/17 16:07:06]

Thanks for your review. Hopefully such a small change will be quick and painless
for both the reviewer and reviewee.

+
   // Compares this value map against |other| and stores all key names that have
   // different values in |differing_keys|. This includes keys that are present
   // only in one of the maps.