Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Side by Side Diff: tools/json_schema_compiler/test/simple_api_unittest.cc

Issue 390233003: Decrement CreateDoubleValue count (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "tools/json_schema_compiler/test/simple_api.h" 5 #include "tools/json_schema_compiler/test/simple_api.h"
6 6
7 #include "testing/gtest/include/gtest/gtest.h" 7 #include "testing/gtest/include/gtest/gtest.h"
8 8
9 using namespace test::api::simple_api; 9 using namespace test::api::simple_api;
10 10
11 namespace { 11 namespace {
12 12
13 static scoped_ptr<base::DictionaryValue> CreateTestTypeDictionary() { 13 static scoped_ptr<base::DictionaryValue> CreateTestTypeDictionary() {
14 scoped_ptr<base::DictionaryValue> value(new base::DictionaryValue()); 14 scoped_ptr<base::DictionaryValue> value(new base::DictionaryValue());
15 value->SetWithoutPathExpansion("number", 15 value->SetWithoutPathExpansion("number",
16 base::Value::CreateDoubleValue(1.1)); 16 new base::FundamentalValue(1.1));
17 value->SetWithoutPathExpansion("integer", 17 value->SetWithoutPathExpansion("integer",
18 base::Value::CreateIntegerValue(4)); 18 base::Value::CreateIntegerValue(4));
19 value->SetWithoutPathExpansion("string", 19 value->SetWithoutPathExpansion("string",
20 base::Value::CreateStringValue("bling")); 20 base::Value::CreateStringValue("bling"));
21 value->SetWithoutPathExpansion("boolean", 21 value->SetWithoutPathExpansion("boolean",
22 base::Value::CreateBooleanValue(true)); 22 base::Value::CreateBooleanValue(true));
23 return value.Pass(); 23 return value.Pass();
24 } 24 }
25 25
26 } // namespace 26 } // namespace
(...skipping 150 matching lines...) Expand 10 before | Expand all | Expand 10 after
177 ASSERT_TRUE(expected->GetInteger("integer", &some_test_type.integer)); 177 ASSERT_TRUE(expected->GetInteger("integer", &some_test_type.integer));
178 ASSERT_TRUE(expected->GetBoolean("boolean", &some_test_type.boolean)); 178 ASSERT_TRUE(expected->GetBoolean("boolean", &some_test_type.boolean));
179 179
180 scoped_ptr<base::ListValue> results( 180 scoped_ptr<base::ListValue> results(
181 OnTestTypeFired::Create(some_test_type)); 181 OnTestTypeFired::Create(some_test_type));
182 base::DictionaryValue* result = NULL; 182 base::DictionaryValue* result = NULL;
183 results->GetDictionary(0, &result); 183 results->GetDictionary(0, &result);
184 EXPECT_TRUE(result->Equals(expected.get())); 184 EXPECT_TRUE(result->Equals(expected.get()));
185 } 185 }
186 } 186 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698