Decrement CreateDoubleValue count

components/policy/core/common/registry_dict_win.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/policy/core/common/registry_dict_win.h"
 
 #include "base/json/json_reader.h"
 #include "base/stl_util.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
@@ skipping 71 matching lines @@
         return scoped_ptr<base::Value>(
             base::Value::CreateIntegerValue(int_value));
       }
       break;
     }
     case base::Value::TYPE_DOUBLE: {
       // Doubles may be string-encoded or integer-encoded.
       double double_value = 0;
       if (value.GetAsInteger(&int_value)) {
         return scoped_ptr<base::Value>(
-            base::Value::CreateDoubleValue(int_value));
+            new base::FundamentalValue(int_value));

[battre, 2014/07/16 07:37:12]

Do you want to cast to double here? Otherwise you change the type of the result.
I did not check whether this has an impact anywhere downstream.

[bartfab (slow), 2014/07/16 09:07:55]

Yes, you definitely want to cast. Otherwise, the policy will have an incorrect
type and there will be a CHECK or DCHECK failure later on.

[battre, 2014/07/16 09:53:20]

Maybe that is an indication that going for an overloaded constructor is a bad
move.

[Evan Stade, 2014/07/16 22:15:25]

Equally, I think it's an indication that this code should not have been relying
on an implicit cast. Luckily, several tests caught this as well. Going forward,
I don't think the overloaded constructor is more likely to cause bugs (although
I will grant it is a potential source of regressions in the switch over).

       } else if (value.GetAsString(&string_value) &&
                  base::StringToDouble(string_value, &double_value)) {
         return scoped_ptr<base::Value>(
-            base::Value::CreateDoubleValue(double_value));
+            new base::FundamentalValue(double_value));
       }
       break;
     }
     case base::Value::TYPE_LIST: {
       // Lists are encoded as subkeys with numbered value in the registry.
       const base::DictionaryValue* dict = NULL;
       if (value.GetAsDictionary(&dict)) {
         scoped_ptr<base::ListValue> result(new base::ListValue());
         for (int i = 1; ; ++i) {
           const base::Value* entry = NULL;
@@ skipping 237 matching lines @@
       return result.PassAs<base::Value>();
     }
     default:
       LOG(WARNING) << "Can't convert registry key to schema type " << type;
   }
 
   return scoped_ptr<base::Value>();
 }
 
 }  // namespace policy