tools/telemetry/telemetry/results/page_measurement_results.py - Issue 390233002: Kill AddError/AddErrorMessage from PageTestResults.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/results/page_measurement_results.py

Issue 390233002: Kill AddError/AddErrorMessage from PageTestResults. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and simplify unit test a bit. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/results/page_measurement_results.py

diff --git a/tools/telemetry/telemetry/results/page_measurement_results.py b/tools/telemetry/telemetry/results/page_measurement_results.py

index 45a57e57f4edd5d3af262b40a80436990151bce0..0c3b3f96a0e5687568ffd47f163b483ae12f63a1 100644

--- a/tools/telemetry/telemetry/results/page_measurement_results.py

+++ b/tools/telemetry/telemetry/results/page_measurement_results.py

@@ -23,7 +23,7 @@ class PageMeasurementResults(page_test_results.PageTestResults):

@property

def pages_that_succeeded(self):

pages = set([value.page for value in self._all_page_specific_values])

- pages.difference_update(self.pages_that_had_errors_or_failures)

+ pages.difference_update(self.pages_that_had_failures)

return pages

@property