Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: tools/telemetry/telemetry/results/gtest_test_results.py

Issue 390233002: Kill AddError/AddErrorMessage from PageTestResults. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase and simplify unit test a bit. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/results/gtest_test_results.py
diff --git a/tools/telemetry/telemetry/results/gtest_test_results.py b/tools/telemetry/telemetry/results/gtest_test_results.py
index fc3757ba37a7cdecde156a4c42b55ca11a89acc3..d88519cff9b810f536d20b35272a19b4373d3211 100644
--- a/tools/telemetry/telemetry/results/gtest_test_results.py
+++ b/tools/telemetry/telemetry/results/gtest_test_results.py
@@ -22,10 +22,6 @@ class GTestTestResults(page_test_results.PageTestResults):
'(%0.f ms)' % self._GetMs())
self._output_stream.flush()
- def AddError(self, page, err):
- super(GTestTestResults, self).AddError(page, err)
- self._emitFailure(page, err)
-
def AddFailure(self, page, err):
super(GTestTestResults, self).AddFailure(page, err)
self._emitFailure(page, err)
@@ -56,17 +52,15 @@ class GTestTestResults(page_test_results.PageTestResults):
unit = 'test' if len(self.successes) == 1 else 'tests'
print >> self._output_stream, '[ PASSED ]', (
'%d %s.' % (len(self.successes), unit))
- if self.errors or self.failures:
- all_errors = self.errors[:]
- all_errors.extend(self.failures)
- unit = 'test' if len(all_errors) == 1 else 'tests'
+ if self.failures:
+ unit = 'test' if len(self.failures) == 1 else 'tests'
print >> self._output_stream, '[ FAILED ]', (
- '%d %s, listed below:' % (len(all_errors), unit))
- for page, _ in all_errors:
+ '%d %s, listed below:' % (len(self.failures), unit))
+ for page, _ in self.failures:
print >> self._output_stream, '[ FAILED ] ', (
page.display_name)
print >> self._output_stream
- count = len(self.errors) + len(self.failures)
+ count = len(self.failures)
unit = 'TEST' if count == 1 else 'TESTS'
print >> self._output_stream, '%d FAILED %s' % (count, unit)
print >> self._output_stream

Powered by Google App Engine
This is Rietveld 408576698