Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1189)

Unified Diff: tools/telemetry/telemetry/page/page_runner.py

Issue 390233002: Kill AddError/AddErrorMessage from PageTestResults. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase and simplify unit test a bit. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/benchmark.py ('k') | tools/telemetry/telemetry/page/page_runner_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/page/page_runner.py
diff --git a/tools/telemetry/telemetry/page/page_runner.py b/tools/telemetry/telemetry/page/page_runner.py
index 2ea2ad35cdc685e0b4268811e49e7d1dd984ad72..5b2a6c5b2d05e932a2e4ccaf03eab55a714f87b4 100644
--- a/tools/telemetry/telemetry/page/page_runner.py
+++ b/tools/telemetry/telemetry/page/page_runner.py
@@ -423,10 +423,6 @@ def Run(test, page_set, expectations, finder_options):
len(results.failures) > test.max_failures):
logging.error('Too many failures. Aborting.')
test.RequestExit()
- if (not test.max_errors is None and
- len(results.errors) > test.max_errors):
- logging.error('Too many errors. Aborting.')
- test.RequestExit()
if test.IsExiting():
break
state.repeat_state.DidRunPageSet()
@@ -500,7 +496,7 @@ def _CheckArchives(page_set, pages, results):
for page in pages_missing_archive_path + pages_missing_archive_data:
results.StartTest(page)
- results.AddErrorMessage(page, 'Page set archive doesn\'t exist.')
+ results.AddFailureMessage(page, 'Page set archive doesn\'t exist.')
results.StopTest(page)
return [page for page in pages if page not in
@@ -523,7 +519,7 @@ def _RunPage(test, page, state, expectation, results, finder_options):
results.AddSuccess(page)
else:
msg = 'Exception while running %s' % page.url
- results.AddError(page, sys.exc_info())
+ results.AddFailure(page, sys.exc_info())
exception_formatter.PrintFormattedException(msg=msg)
try:
« no previous file with comments | « tools/telemetry/telemetry/benchmark.py ('k') | tools/telemetry/telemetry/page/page_runner_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698