Kill AddError/AddErrorMessage from PageTestResults.

tools/telemetry/telemetry/value/summary.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from collections import defaultdict
 
 from telemetry.value import merge_values
 
 class Summary(object):
   """Computes summary values from the per-page-run values produced by a test.
@@ skipping 14 matching lines @@
          ListOfScalarValues(page1, 'foo', units='ms', [1,1,1])],
          ListOfScalarValues(page2, 'foo', units='ms', [2])]
       ]
 
   In addition, it will produce a summary value:
       [
          ListOfScalarValues(page=None, 'foo', units='ms', [1,1,1,2])]
       ]
 
   """
-  def __init__(self, all_page_specific_values, had_errors_or_failures):
-    self.had_errors_or_failures = had_errors_or_failures
+  def __init__(self, all_page_specific_values, had_failures):
+    self.had_failures = had_failures
     self._computed_per_page_values = []
     self._computed_summary_values = []
     self._interleaved_computed_per_page_values_and_summaries = []
     self._ComputePerPageValues(all_page_specific_values)
 
   @property
   def computed_per_page_values(self):
     return self._computed_per_page_values
 
   @property
@@ skipping 46 matching lines @@
     # that name.
     per_page_values_by_value_name = defaultdict(list)
     for value in merged_page_values:
       per_page_values_by_value_name[value.name].append(value)
 
     # We already have the x values in the values array. But, we also need
     # the values merged across the pages. And, we will need them indexed by
     # value name so that we can find them when printing out value names in
     # alphabetical order.
     merged_pages_value_by_value_name = {}
-    if not self.had_errors_or_failures:
+    if not self.had_failures:
       for value in merge_values.MergeLikeValuesFromDifferentPages(
           all_successful_page_values):
         assert value.name not in merged_pages_value_by_value_name
         merged_pages_value_by_value_name[value.name] = value
 
     # sorted_value names will govern the order we start printing values.
     value_names = set([v.name for v in merged_page_values])
     sorted_value_names = sorted(value_names)
 
     # Time to walk through the values by name, printing first the page-specific
@@ skipping 21 matching lines @@
         self._interleaved_computed_per_page_values_and_summaries.append(
             merged_pages_value)
 
   def _ComputePerPageValue(
       self, value, num_successful_pages_for_this_value_name):
     # If there were any page errors, we typically will print nothing.
     #
     # Note: this branch is structured less-densely to improve legibility.
     if num_successful_pages_for_this_value_name > 1:
       should_print = True
-    elif (self.had_errors_or_failures and
+    elif (self.had_failures and
          num_successful_pages_for_this_value_name == 1):
       should_print = True
     else:
       should_print = False
 
     if not should_print:
       return
 
     # Actually save the result.
     self._computed_per_page_values.append(value)
     self._interleaved_computed_per_page_values_and_summaries.append(value)