Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Side by Side Diff: tools/telemetry/telemetry/results/page_test_results_unittest.py

Issue 390233002: Kill AddError/AddErrorMessage from PageTestResults. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 import os 4 import os
5 from telemetry.results import base_test_results_unittest 5 from telemetry.results import base_test_results_unittest
6 6
7 from telemetry.page import page_set 7 from telemetry.page import page_set
8 from telemetry.results import page_test_results 8 from telemetry.results import page_test_results
9 9
10 class NonPrintingPageTestResults( 10 class NonPrintingPageTestResults(
(...skipping 15 matching lines...) Expand all
26 def pages(self): 26 def pages(self):
27 return self.page_set.pages 27 return self.page_set.pages
28 28
29 def test_failures(self): 29 def test_failures(self):
30 results = NonPrintingPageTestResults() 30 results = NonPrintingPageTestResults()
31 results.AddFailure(self.pages[0], self.CreateException()) 31 results.AddFailure(self.pages[0], self.CreateException())
32 results.AddSuccess(self.pages[1]) 32 results.AddSuccess(self.pages[1])
33 self.assertEquals(results.pages_that_had_failures, 33 self.assertEquals(results.pages_that_had_failures,
34 set([self.pages[0]])) 34 set([self.pages[0]]))
35 self.assertEquals(results.successes, [self.pages[1]]) 35 self.assertEquals(results.successes, [self.pages[1]])
36
37 def test_errors(self):
38 results = NonPrintingPageTestResults()
39 results.AddError(self.pages[0], self.CreateException())
40 results.AddSuccess(self.pages[1])
41 self.assertEquals(results.pages_that_had_errors,
42 set([self.pages[0]]))
43 self.assertEquals(results.successes, [self.pages[1]])
44
45 def test_errors_and_failures(self):
46 results = NonPrintingPageTestResults()
47 results.AddError(self.pages[0], self.CreateException())
48 results.AddError(self.pages[1], self.CreateException())
49 results.AddSuccess(self.pages[2])
50 self.assertEquals(results.pages_that_had_errors_or_failures,
51 set([self.pages[0], self.pages[1]]))
52 self.assertEquals(results.successes, [self.pages[2]])
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698