Kill AddError/AddErrorMessage from PageTestResults.

tools/telemetry/telemetry/results/gtest_test_results_unittest.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 import os
 import traceback
 
 from telemetry.page import page_set
 from telemetry.results import base_test_results_unittest
 from telemetry.results import gtest_test_results
 from telemetry.unittest import simple_mock
@@ skipping 51 matching lines @@
     exception_trace = ''.join(traceback.format_exception(*exception))
     expected = ('[ RUN      ] http://www.foo.com/\n'
                 '%s\n'
                 '[  FAILED  ] http://www.foo.com/ (0 ms)\n'
                 '[  PASSED  ] 0 tests.\n'
                 '[  FAILED  ] 1 test, listed below:\n'
                 '[  FAILED  ]  http://www.foo.com/\n\n'
                 '1 FAILED TEST\n\n' % exception_trace)
     self.assertEquals(expected, ''.join(results.output_data))
 
-  def testSingleErrorPage(self):
-    test_page_set = _MakePageSet()
-    results = SummaryGtestTestResults()
-    results.StartTest(test_page_set.pages[0])
-    exception = self.CreateException()
-    results.AddError(test_page_set.pages[0], exception)
-    results.PrintSummary()
-    exception_trace = ''.join(traceback.format_exception(*exception))
-    expected = ('[ RUN      ] http://www.foo.com/\n'
-                '%s\n'
-                '[  FAILED  ] http://www.foo.com/ (0 ms)\n'
-                '[  PASSED  ] 0 tests.\n'
-                '[  FAILED  ] 1 test, listed below:\n'
-                '[  FAILED  ]  http://www.foo.com/\n\n'
-                '1 FAILED TEST\n\n' % exception_trace)
-    self.assertEquals(expected, ''.join(results.output_data))
-
   def testSingleSkippedPage(self):
     test_page_set = _MakePageSet()
     results = SummaryGtestTestResults()
     results.StartTest(test_page_set.pages[0])
     self._mock_timer.SetTime(0.007)
     results.AddSkip(test_page_set.pages[0], 'Page skipped for testing reason')
     results.PrintSummary()
     expected = ('[ RUN      ] http://www.foo.com/\n'
                 '[       OK ] http://www.foo.com/ (7 ms)\n'
                 '[  PASSED  ] 0 tests.\n\n')
     self.assertEquals(expected, ''.join(results.output_data))
 
   def testPassAndFailedPages(self):
     test_page_set = _MakePageSet()
     results = SummaryGtestTestResults()
     exception = self.CreateException()
 
     results.StartTest(test_page_set.pages[0])
     self._mock_timer.SetTime(0.007)
     results.AddSuccess(test_page_set.pages[0])
 
     results.StartTest(test_page_set.pages[1])
     self._mock_timer.SetTime(0.009)
-    results.AddError(test_page_set.pages[1], exception)
+    results.AddFailure(test_page_set.pages[1], exception)
 
     results.StartTest(test_page_set.pages[2])
     self._mock_timer.SetTime(0.015)
     results.AddFailure(test_page_set.pages[2], exception)
 
     results.StartTest(test_page_set.pages[3])
     self._mock_timer.SetTime(0.020)
     results.AddSuccess(test_page_set.pages[3])
 
     results.PrintSummary()
@@ skipping 23 matching lines @@
     results.StartTest(test_page_set.pages[0])
     self._mock_timer.SetTime(0.007)
     results.AddSuccess(test_page_set.pages[0])
     expected = ('[ RUN      ] http://www.foo.com/\n'
                 '[       OK ] http://www.foo.com/ (7 ms)\n')
     self.assertEquals(expected, ''.join(results.output_data))
 
     results.StartTest(test_page_set.pages[1])
     self._mock_timer.SetTime(0.009)
     exception_trace = ''.join(traceback.format_exception(*exception))
-    results.AddError(test_page_set.pages[1], exception)
+    results.AddFailure(test_page_set.pages[1], exception)
     expected = ('[ RUN      ] http://www.foo.com/\n'
                 '[       OK ] http://www.foo.com/ (7 ms)\n'
                 '[ RUN      ] http://www.bar.com/\n'
                 '%s\n'
                 '[  FAILED  ] http://www.bar.com/ (2 ms)\n' % exception_trace)
 
   def tearDown(self):
     gtest_test_results.time.time = self._real_gtest_time_time