Source/bindings/templates/attributes.cpp - Issue 390223004: initialize result variables in v8 bindings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/templates/attributes.cpp

Issue 390223004: initialize result variables in v8 bindings (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/templates/attributes.cpp

diff --git a/Source/bindings/templates/attributes.cpp b/Source/bindings/templates/attributes.cpp

index 6b0335abbe8629bf4ae923e71abd154bfdc13ed6..ac1c3457d83ffe56a887676c97e165895aef33d3 100644

--- a/Source/bindings/templates/attributes.cpp

+++ b/Source/bindings/templates/attributes.cpp

@@ -50,7 +50,7 @@ const v8::PropertyCallbackInfo<v8::Value>& info

bool isNull = false;

{% endif %}

{% if attribute.is_implemented_in_private_script %}

- {{attribute.cpp_type}} result;

+ {{attribute.cpp_type}} result{% if attribute.cpp_type == 'int' %} = 0{% endif %};

if (!{{attribute.cpp_value_original}})

return;

{% elif attribute.cpp_value_original %}