chrome/browser/debugger/debugger_node.cc - Issue 39022: Convert NavigationEntry title to string16. TabContents::GetTitle no longer ne...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/debugger/debugger_node.cc

Issue 39022: Convert NavigationEntry title to string16. TabContents::GetTitle no longer ne... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 11 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/debugger/debugger_node.cc

===================================================================

--- chrome/browser/debugger/debugger_node.cc (revision 10809)

+++ chrome/browser/debugger/debugger_node.cc (working copy)

@@ -201,7 +201,7 @@

if (b != NULL) {

if (prop->Equals(v8::String::New("title"))) {

const TabContents *t = b->GetSelectedTabContents();

- std::wstring title = t->GetTitle();

+ std::wstring title = UTF16ToWideHack(t->GetTitle());

std::string title2 = WideToUTF8(title);

return v8::String::New(title2.c_str());

} else if (prop->Equals(v8::String::New("tab"))) {

@@ -359,7 +359,7 @@

if (t != NULL) {

WebContents* web = t->AsWebContents();

if (prop->Equals(v8::String::New("title"))) {

- std::wstring title = t->GetTitle();

+ std::wstring title = UTF16ToWideHack(t->GetTitle());

std::string title2 = WideToUTF8(title);

return v8::String::New(title2.c_str());

} else if (web) {

« no previous file with comments | « chrome/browser/debugger/debugger_host_impl.cpp ('k') | chrome/browser/memory_details.cc » ('j') | no next file with comments »