Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Issue 39022: Convert NavigationEntry title to string16. TabContents::GetTitle no longer ne... (Closed)

Created:
11 years, 9 months ago by brettw
Modified:
9 years, 7 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Convert NavigationEntry title to string16. TabContents::GetTitle no longer needs to be virtual, either. This also changes how the display URL is computed. Instead of doing it preemptively, we now do so lazily. This allows us to do the URL formatting correctly using the elider so that we can do IDN and unescaping. I changed string_util's singleton functions. I was worried that other code might make a singleton of string, which would give you this same value as a non-const string. This would mean our empty strings might no longer be empty. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10872

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -74 lines) Patch
M base/string_util.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M base/string_util.cc View 1 2 2 chunks +16 lines, -2 lines 0 comments Download
M chrome/browser/browser.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/debugger/debugger_host_impl.cpp View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/debugger/debugger_node.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/memory_details.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/navigation_entry_unittest.cc View 1 2 5 chunks +10 lines, -8 lines 0 comments Download
M chrome/browser/printing/print_view_manager.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/navigation_controller.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/navigation_controller.cc View 1 2 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/tab_contents/navigation_entry.h View 1 2 8 chunks +20 lines, -16 lines 0 comments Download
M chrome/browser/tab_contents/navigation_entry.cc View 1 2 3 chunks +31 lines, -5 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/tab_contents.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/tab_contents/web_contents.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/task_manager_resource_providers.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/blocked_popup_container.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/views/bug_report_view.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/hung_renderer_view.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/location_bar_view.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/sad_tab_view.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/views/star_toggle.h View 1 2 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/views/tab_icon_view.h View 1 2 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/views/tabs/tab_renderer.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/toolbar_view.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
11 years, 9 months ago (2009-03-03 18:12:28 UTC) #1
brettw
11 years, 9 months ago (2009-03-03 19:22:23 UTC) #2

          

Powered by Google App Engine
This is Rietveld 408576698