Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Unified Diff: ppapi/cpp/video_decoder.h

Issue 390213002: Pepper: Change PPB_VideoDecoder::Reset behavior so plugin always manages textures. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/cpp/video_decoder.h
diff --git a/ppapi/cpp/video_decoder.h b/ppapi/cpp/video_decoder.h
index d1eded3059c1d17f645e1b9f06cc6ba67f6cd812..c3a2a7c2fdbfef1fed1b5887d4974a9621afb382 100644
--- a/ppapi/cpp/video_decoder.h
+++ b/ppapi/cpp/video_decoder.h
@@ -149,8 +149,8 @@ class VideoDecoder : public Resource {
/// the decoder signals completion by running |callback|. Just before
/// completion, any pending GetPicture() call will complete by running its
/// callback with result PP_ERROR_ABORTED to signal that no more pictures are
- /// available. The plugin should recycle any pictures it is using before
- /// resuming decoding.
+ /// available. Any pictures held by the plugin remain valid during and after
+ /// the flush and should be recycled back to the decoder.
///
/// @param[in] callback A <code>CompletionCallback</code> to be called on
/// completion.
@@ -163,9 +163,10 @@ class VideoDecoder : public Resource {
/// skip to another position in the video stream. After Reset() returns, any
/// pending calls to Decode() and GetPicture()) abort, causing their callbacks
/// to run with PP_ERROR_ABORTED. The plugin should not make further calls to
- /// the decoder until the decoder signals completion by running |callback|.
- /// The pictures in use by the plugin remain valid until decoding is resumed,
- /// but need not be recycled.
+ /// the decoder other than RecyclePicture() until the decoder signals
+ /// completion by running |callback|. Any pictures held by the plugin remain
+ /// valid during and after the reset and should be recycled back to the
+ /// decoder.
///
/// @param[in] callback A <code>CompletionCallback</code> to be called on
/// completion.

Powered by Google App Engine
This is Rietveld 408576698