Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 390203003: Fix some issues with sfnt maxp headers. (Closed)

Created:
6 years, 5 months ago by bungeman-skia
Modified:
6 years, 5 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Fix some issues with sfnt maxp headers. The TT version was missing the second to last member, and the names of the asserts in the CFF version were wrong. Committed: https://skia.googlesource.com/skia/+/9d3cdb6886a6a6ee41aea32b04bb950b565cdd9f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M src/sfnt/SkOTTable_maxp_CFF.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/sfnt/SkOTTable_maxp_TT.h View 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
bungeman-skia
Since you were pointing out that you caught me doing this before...
6 years, 5 months ago (2014-07-15 14:33:39 UTC) #1
mtklein
lgtm
6 years, 5 months ago (2014-07-15 19:35:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bungeman@google.com/390203003/1
6 years, 5 months ago (2014-07-15 19:35:59 UTC) #3
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 03:02:02 UTC) #4
Message was sent while issue was closed.
Change committed as 9d3cdb6886a6a6ee41aea32b04bb950b565cdd9f

Powered by Google App Engine
This is Rietveld 408576698