Issue 390203003: Fix some issues with sfnt maxp headers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 390203003: Fix some issues with sfnt maxp headers. (Closed)

Created:
6 years, 5 months ago by bungeman-skia

Modified:
6 years, 5 months ago

Reviewers:
mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Fix some issues with sfnt maxp headers. The TT version was missing the second to last member, and the names of the asserts in the CFF version were wrong. Committed: https://skia.googlesource.com/skia/+/9d3cdb6886a6a6ee41aea32b04bb950b565cdd9f

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -5 lines)			Patch
	M	src/sfnt/SkOTTable_maxp_CFF.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	src/sfnt/SkOTTable_maxp_TT.h	View		3 chunks	+4 lines, -3 lines	0 comments	Download

Total messages: 4 (0 generated)

bungeman-skia

Since you were pointing out that you caught me doing this before...

6 years, 5 months ago (2014-07-15 14:33:39 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bungeman@google.com/390203003/1

6 years, 5 months ago (2014-07-15 19:35:59 UTC) #3

commit-bot: I haz the power

6 years, 5 months ago (2014-07-16 03:02:02 UTC) #4

Message was sent while issue was closed.

Change committed as 9d3cdb6886a6a6ee41aea32b04bb950b565cdd9f