[not for review] Add Draw entries to window Performance Timeline

Source/core/rendering/RenderView.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
@@ skipping 438 matching lines @@
     ASSERT(!needsLayout());
 
     // We specifically need to repaint the viewRect since other renderers
     // short-circuit on full-repaint.
     if (doingFullRepaint() && !viewRect().isEmpty())
         repaintViewRectangle(viewRect());
 
     RenderBlock::invalidateTreeAfterLayout(paintInvalidationState);
 }
 
+LayoutRect RenderView::rectForPaintInvalidation(const LayoutRect* repaintRectPtr) const
+{
+    if (document().printing() || !m_frameView)
+        return LayoutRect();
+    LayoutRect repaintRect = repaintRectPtr ? *repaintRectPtr : viewRect();

[chrishtr, 2014/07/16 20:00:25]

You need to put line 463 at the top of the function, and return it unchanged in
the printing() and other fallbacks.

+    Element* owner = document().ownerElement();
+    if (layer()->compositingState() == PaintsIntoOwnBacking || !owner)
+        return repaintRect;
+    if (RenderBox* obj = owner->renderBox()) {
+        LayoutRect viewRectangle = viewRect();
+        LayoutRect rectToRepaint = intersection(repaintRect, viewRectangle);
+
+        // Subtract out the contentsX and contentsY offsets to get our coords within the viewing
+        // rectangle.
+        rectToRepaint.moveBy(-viewRectangle.location());
+
+        // FIXME: Hardcoded offsets here are not good.
+        rectToRepaint.moveBy(obj->contentBoxRect().location());
+        return rectToRepaint;
+    }
+    return LayoutRect();

[chrishtr, 2014/07/16 20:00:25]

return repaintRect;

+}
+
 void RenderView::repaintViewRectangle(const LayoutRect& repaintRect) const
 {
     ASSERT(!repaintRect.isEmpty());
 
     if (document().printing() || !m_frameView)
         return;
 
     // We always just invalidate the root view, since we could be an iframe that is clipped out
     // or even invisible.
     Element* owner = document().ownerElement();
     if (layer()->compositingState() == PaintsIntoOwnBacking) {
         layer()->repainter().setBackingNeedsRepaintInRect(repaintRect);
     } else if (!owner) {
         m_frameView->contentRectangleForPaintInvalidation(pixelSnappedIntRect(repaintRect));
     } else if (RenderBox* obj = owner->renderBox()) {
-        LayoutRect viewRectangle = viewRect();
-        LayoutRect rectToRepaint = intersection(repaintRect, viewRectangle);
-
-        // Subtract out the contentsX and contentsY offsets to get our coords within the viewing
-        // rectangle.
-        rectToRepaint.moveBy(-viewRectangle.location());
-
-        // FIXME: Hardcoded offsets here are not good.
-        rectToRepaint.moveBy(obj->contentBoxRect().location());
-        obj->invalidatePaintRectangle(rectToRepaint);
+        obj->invalidatePaintRectangle(rectForPaintInvalidation(&repaintRect));
     }
 }
 
 void RenderView::repaintViewAndCompositedLayers()
 {
     paintInvalidationForWholeRenderer();
 
     // The only way we know how to hit these ASSERTS below this point is via the Chromium OS login screen.
     DisableCompositingQueryAsserts disabler;
 
@@ skipping 499 matching lines @@
     return viewWidth(IncludeScrollbars) / scale;
 }
 
 double RenderView::layoutViewportHeight() const
 {
     float scale = m_frameView ? m_frameView->frame().pageZoomFactor() : 1;
     return viewHeight(IncludeScrollbars) / scale;
 }
 
 } // namespace WebCore