Issue 390183005: Avoid crash in FontFallbackList when LastResortFallbackFont is null

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 390183005: Avoid crash in FontFallbackList when LastResortFallbackFont is null (Closed)

Created:
6 years, 5 months ago by Kunihiko Sakamoto

Modified:
6 years, 5 months ago

Reviewers:
eae

CC:
blink-reviews, jamesr, krit, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis, scottmg

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Avoid crash in FontFallbackList when LastResortFallbackFont is null Blink r176963 made FontFallbackList::determinePrimarySimpleFontData crash when getLastResortFallbackFont() returns null, but callers may be able to handle a NULL return (see also http://crbug.com/383542#c23). This patch lets determinePrimarySimpleFontData() propagate NULL returns to the callers. BUG=389536, 390272, 390284 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178302