Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 390183003: Get rid of more uses of CreateStringValue (Closed)

Created:
6 years, 5 months ago by Evan Stade
Modified:
6 years, 5 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Get rid of more uses of CreateStringValue split off from https://codereview.chromium.org/388963002/ BUG=160586 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283537

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -44 lines) Patch
M chromeos/dbus/fake_shill_device_client.cc View 1 chunk +8 lines, -11 lines 0 comments Download
M chromeos/dbus/fake_shill_manager_client.cc View 4 chunks +10 lines, -10 lines 0 comments Download
M chromeos/dbus/gsm_sms_client_unittest.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M chromeos/dbus/shill_client_unittest_base.cc View 2 chunks +6 lines, -9 lines 0 comments Download
M chromeos/dbus/shill_ipconfig_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/shill_manager_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/shill_profile_client_unittest.cc View 3 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Evan Stade
you already reviewed these changes, but I've split them off from the other CL because ...
6 years, 5 months ago (2014-07-15 00:06:10 UTC) #1
stevenjb
lgtm
6 years, 5 months ago (2014-07-15 00:38:05 UTC) #2
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 5 months ago (2014-07-15 19:29:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/390183003/1
6 years, 5 months ago (2014-07-15 19:30:31 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-16 00:43:56 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-16 01:07:16 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/170713)
6 years, 5 months ago (2014-07-16 01:07:16 UTC) #7
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 5 months ago (2014-07-16 22:00:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/390183003/1
6 years, 5 months ago (2014-07-16 22:04:04 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 22:07:52 UTC) #10
Message was sent while issue was closed.
Change committed as 283537

Powered by Google App Engine
This is Rietveld 408576698