Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 390183002: MacViews: Move menu run types parameter to constructor. (Closed)

Created:
6 years, 5 months ago by Andre
Modified:
6 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews, asanka, sadrul, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, dmazzoni+watch_chromium.org, markusheintz_, benjhayden+dwatch_chromium.org, Ilya Sherman, extensions-reviews_chromium.org, aboxhall+watch_chromium.org, jam, nona+watch_chromium.org, darin-cc_chromium.org, rouslan+autofillwatch_chromium.org, chromium-apps-reviews_chromium.org, dtseng+watch_chromium.org, penghuang+watch_chromium.org, yuzo+watch_chromium.org, kalyank, jochen+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, plundblad+watch_chromium.org, tfarina, benquan, Dane Wallinga, dyu1, estade+watch_chromium.org, James Su, ben+ash_chromium.org, mac-views-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

MacViews: Move menu run types parameter to constructor. This is in preparation for supporting running native Cocoa context menus to support Services (https://codereview.chromium.org/331993009/). The parameter is moved to the constructor so that we can know which kind of MenuRunnerImpl to create at construction time. TBR=sky@chromium.org BUG=388455 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283114

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+245 lines, -249 lines) Patch
M ash/root_window_controller.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M ash/shelf/shelf_view.cc View 2 chunks +7 lines, -8 lines 0 comments Download
M ash/shell/window_type_launcher.cc View 1 chunk +7 lines, -9 lines 0 comments Download
M ash/shell_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/accessibility/accessibility_event_router_views_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/apps/chrome_native_app_window_views.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/autofill/autofill_dialog_views.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_context_menu.cc View 2 chunks +9 lines, -11 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.cc View 2 chunks +12 lines, -10 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_menu_delegate_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/content_setting_bubble_contents.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/download/download_shelf_context_menu_view.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc View 5 chunks +17 lines, -18 lines 0 comments Download
M chrome/browser/ui/views/extensions/media_galleries_dialog_views.cc View 1 chunk +8 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_frame.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/infobars/infobar_view.cc View 1 chunk +7 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/location_bar/page_action_image_view.cc View 1 chunk +8 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/menu_model_adapter_test.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/menu_test_base.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_views.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/status_icons/status_icon_win.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/task_manager_view.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/toolbar/browser_action_view.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/toolbar/browser_actions_container.cc View 2 chunks +16 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_button.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/toolbar/wrench_menu.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/website_settings/permission_selector_view.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/website_settings/permissions_bubble_view.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/shell/browser/shell_views.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M ui/app_list/views/app_list_item_view.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/app_list/views/app_list_menu_views.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M ui/app_list/views/search_result_view.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/message_center/views/message_view_context_menu_controller.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/message_center/views/notifier_settings_view.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M ui/views/controls/combobox/combobox.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M ui/views/controls/menu/menu_model_adapter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/menu/menu_runner.h View 5 chunks +8 lines, -7 lines 0 comments Download
M ui/views/controls/menu/menu_runner.cc View 3 chunks +11 lines, -11 lines 0 comments Download
M ui/views/controls/scrollbar/base_scroll_bar.cc View 2 chunks +7 lines, -9 lines 0 comments Download
M ui/views/controls/textfield/textfield.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M ui/views/examples/menu_example.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ui/views/examples/tree_view_example.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Andre
6 years, 5 months ago (2014-07-14 22:05:02 UTC) #1
Andre
The CQ bit was checked by andresantoso@chromium.org
6 years, 5 months ago (2014-07-14 22:08:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andresantoso@chromium.org/390183002/1
6 years, 5 months ago (2014-07-14 22:09:17 UTC) #3
commit-bot: I haz the power
6 years, 5 months ago (2014-07-15 00:42:36 UTC) #4
Message was sent while issue was closed. 
Change committed as 283114

Powered by Google App Engine
This is Rietveld 408576698