Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Side by Side Diff: test/mjsunit/regexp-string-methods.js

Issue 39010: Removed some handlers and made regexp.test avoid creating a result array. (Closed)
Patch Set: Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« src/jsregexp.cc ('K') | « src/regexp-delay.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2009 the V8 project authors. All rights reserved. 1 // Copyright 2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 26 matching lines...) Expand all
37 assertEquals("F", f1.exec("F")); 37 assertEquals("F", f1.exec("F"));
38 assertEquals("f", "foo".charAt(0)); 38 assertEquals("f", "foo".charAt(0));
39 String.prototype.charAt = function(idx) { return 'g'; }; 39 String.prototype.charAt = function(idx) { return 'g'; };
40 assertEquals("g", "foo".charAt(0)); 40 assertEquals("g", "foo".charAt(0));
41 var f2 = new RegExp("[g]", "i"); 41 var f2 = new RegExp("[g]", "i");
42 assertEquals("G", f2.exec("G")); 42 assertEquals("G", f2.exec("G"));
43 assertTrue(f2.ignoreCase); 43 assertTrue(f2.ignoreCase);
44 44
45 // On the other hand test is defined in a semi-coherent way as a call to exec. 45 // On the other hand test is defined in a semi-coherent way as a call to exec.
46 // 15.10.6.3 46 // 15.10.6.3
47 // SpiderMonkey fails this one. 47 // We match other browsers in using the original value of RegExp.prototype.exec.
48 // I.e., RegExp.prototype.test shouldn't use the current value of
49 // RegExp.prototype.exec.
48 RegExp.prototype.exec = function(string) { return 'x'; } 50 RegExp.prototype.exec = function(string) { return 'x'; }
49 assertTrue(/f/.test('x')); 51 assertFalse(/f/.test('x'));
OLDNEW
« src/jsregexp.cc ('K') | « src/regexp-delay.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698