Issue 39010: Removed some handlers and made regexp.test avoid creating a result array.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 39010: Removed some handlers and made regexp.test avoid creating a result array. (Closed)

Created:
11 years, 9 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Visibility:
Public.

Description

Optimized regexp.test. No longer creates an intermediate string array. Removed some handler code.

Patch Set 1 #

Total comments: 2

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+58 lines, -39 lines)			Patch
M	src/jsregexp.h	View	1 chunk	+6 lines, -7 lines	0 comments	Download
M	src/jsregexp.cc	View	8 chunks	+19 lines, -27 lines	2 comments	Download
M	src/regexp-delay.js	View	1 chunk	+29 lines, -3 lines	0 comments	Download
M	test/mjsunit/regexp-string-methods.js	View	1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

11 years, 9 months ago (2009-03-03 10:44:12 UTC) #2

lgtm

http://codereview.chromium.org/39010/diff/1/2
File src/jsregexp.cc (right):

http://codereview.chromium.org/39010/diff/1/2#newcode332
Line 332: 
Add a NoHandleAllocation here.

http://codereview.chromium.org/39010/diff/1/2#newcode456
Line 456: FixedArray* data = FixedArray::cast(re->data());
NoHandleAllocation

Expand Messages | Collapse Messages