Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 390093002: Instrumented libraries: use package-specific sanitizer blacklists. (Closed)

Created:
6 years, 5 months ago by earthdok
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Instrumented libraries: use package-specific sanitizer blacklists. Previously we used a single blacklist file per sanitizer. The same file was used for Chromium and for every instrumented package. This change allows choosing a different blacklist file for each package, which means that package targets may now depend on the blacklist files, avoiding expensive clobbers. This CL also blacklists two known issues in instrumented libraries. BUG=313751, 367509 R=glider@chromium.org NOTRY=true TEST=MSan interactive_ui_tests, ASan compile Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282959

Patch Set 1 #

Patch Set 2 : undo accidental whitespace change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -7 lines) Patch
A third_party/instrumented_libraries/blacklists/asan/libglib2.0-0.txt View 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/instrumented_libraries/blacklists/msan/libx11-6.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/instrumented_libraries/download_build_install.py View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/instrumented_libraries/instrumented_libraries.gyp View 4 chunks +5 lines, -3 lines 0 comments Download
M third_party/instrumented_libraries/standard_instrumented_package_target.gypi View 2 chunks +14 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
earthdok
6 years, 5 months ago (2014-07-14 16:20:25 UTC) #1
Alexander Potapenko
lgtm
6 years, 5 months ago (2014-07-14 16:24:40 UTC) #2
earthdok
The CQ bit was checked by earthdok@chromium.org
6 years, 5 months ago (2014-07-14 16:25:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/earthdok@chromium.org/390093002/20001
6 years, 5 months ago (2014-07-14 16:26:19 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-14 16:27:31 UTC) #5
Message was sent while issue was closed.
Change committed as 282959

Powered by Google App Engine
This is Rietveld 408576698