Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 390053002: Drop unnecessary receiver validity checks from {Load,Store}IC_Normal. (Closed)

Created:
6 years, 5 months ago by Jakob Kummerow
Modified:
6 years, 5 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Drop unnecessary receiver validity checks from {Load,Store}IC_Normal. Since these builtins are used as handlers after a map check/dispatch, they don't need to check the receiver again. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22391

Patch Set 1 #

Total comments: 2

Patch Set 2 : fixed nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -247 lines) Patch
M src/arm/ic-arm.cc View 1 3 chunks +10 lines, -60 lines 0 comments Download
M src/arm64/ic-arm64.cc View 1 3 chunks +8 lines, -63 lines 0 comments Download
M src/ia32/ic-ia32.cc View 1 4 chunks +13 lines, -62 lines 0 comments Download
M src/x64/ic-x64.cc View 1 3 chunks +13 lines, -62 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Jakob Kummerow
As discussed.
6 years, 5 months ago (2014-07-14 14:55:28 UTC) #1
Toon Verwaest
lgtm with nit https://codereview.chromium.org/390053002/diff/1/src/x64/ic-x64.cc File src/x64/ic-x64.cc (right): https://codereview.chromium.org/390053002/diff/1/src/x64/ic-x64.cc#newcode920 src/x64/ic-x64.cc:920: // The return address is on ...
6 years, 5 months ago (2014-07-14 15:11:58 UTC) #2
Jakob Kummerow
https://codereview.chromium.org/390053002/diff/1/src/x64/ic-x64.cc File src/x64/ic-x64.cc (right): https://codereview.chromium.org/390053002/diff/1/src/x64/ic-x64.cc#newcode920 src/x64/ic-x64.cc:920: // The return address is on the stack. On ...
6 years, 5 months ago (2014-07-14 15:27:13 UTC) #3
Toon Verwaest
lgtm
6 years, 5 months ago (2014-07-14 16:14:01 UTC) #4
Jakob Kummerow
6 years, 5 months ago (2014-07-15 08:07:38 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r22391 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698